refactor: Remove ValidateBasic in cli (#470)

dymensionxyz · Jan 16, 2024 · 87a18a1 · 87a18a1
1 parent 532317a
commit 87a18a1
Show file tree

Hide file tree

Showing 7 changed files with 1 addition and 25 deletions.
diff --git a/x/rollapp/client/cli/tx_create_rollapp.go b/x/rollapp/client/cli/tx_create_rollapp.go
@@ -62,9 +62,6 @@ func CmdCreateRollapp() *cobra.Command {
 				metadatas,
 			)
 
-			if err := msg.ValidateBasic(); err != nil {
-				return err
-			}
 			return tx.GenerateOrBroadcastTxCLI(clientCtx, cmd.Flags(), msg)
 		},
 	}

diff --git a/x/rollapp/client/cli/tx_update_state.go b/x/rollapp/client/cli/tx_update_state.go
@@ -55,9 +55,7 @@ func CmdUpdateState() *cobra.Command {
 				argVersion,
 				argBDs,
 			)
-			if err := msg.ValidateBasic(); err != nil {
-				return err
-			}
+
 			return tx.GenerateOrBroadcastTxCLI(clientCtx, cmd.Flags(), msg)
 		},
 	}

diff --git a/x/sequencer/client/cli/tx_create_sequencer.go b/x/sequencer/client/cli/tx_create_sequencer.go
@@ -50,9 +50,6 @@ func CmdCreateSequencer() *cobra.Command {
 				return err
 			}
 
-			if err := msg.ValidateBasic(); err != nil {
-				return err
-			}
 			return tx.GenerateOrBroadcastTxCLI(clientCtx, cmd.Flags(), msg)
 		},
 	}

diff --git a/x/streamer/client/cli/tx_create_stream.go b/x/streamer/client/cli/tx_create_stream.go
@@ -74,10 +74,6 @@ func NewCmdSubmitCreateStreamProposal() *cobra.Command {
 				return err
 			}
 
-			if err = msg.ValidateBasic(); err != nil {
-				return err
-			}
-
 			txf := tx.NewFactoryCLI(clientCtx, cmd.Flags()).WithTxConfig(clientCtx.TxConfig).WithAccountRetriever(clientCtx.AccountRetriever)
 			return tx.GenerateOrBroadcastTxWithFactory(clientCtx, txf, msg)
 		},

diff --git a/x/streamer/client/cli/tx_replace_distribution.go b/x/streamer/client/cli/tx_replace_distribution.go
@@ -45,10 +45,6 @@ func NewCmdSubmitReplaceStreamDistributionProposal() *cobra.Command {
 				return err
 			}
 
-			if err = msg.ValidateBasic(); err != nil {
-				return err
-			}
-
 			txf := tx.NewFactoryCLI(clientCtx, cmd.Flags()).WithTxConfig(clientCtx.TxConfig).WithAccountRetriever(clientCtx.AccountRetriever)
 			return tx.GenerateOrBroadcastTxWithFactory(clientCtx, txf, msg)
 		},

diff --git a/x/streamer/client/cli/tx_terminate_stream.go b/x/streamer/client/cli/tx_terminate_stream.go
@@ -41,10 +41,6 @@ func NewCmdSubmitTerminateStreamProposal() *cobra.Command {
 				return err
 			}
 
-			if err = msg.ValidateBasic(); err != nil {
-				return err
-			}
-
 			txf := tx.NewFactoryCLI(clientCtx, cmd.Flags()).WithTxConfig(clientCtx.TxConfig).WithAccountRetriever(clientCtx.AccountRetriever)
 			return tx.GenerateOrBroadcastTxWithFactory(clientCtx, txf, msg)
 		},

diff --git a/x/streamer/client/cli/tx_update_distribution.go b/x/streamer/client/cli/tx_update_distribution.go
@@ -45,10 +45,6 @@ func NewCmdSubmitUpdateStreamDistributionProposal() *cobra.Command {
 				return err
 			}
 
-			if err = msg.ValidateBasic(); err != nil {
-				return err
-			}
-
 			txf := tx.NewFactoryCLI(clientCtx, cmd.Flags()).WithTxConfig(clientCtx.TxConfig).WithAccountRetriever(clientCtx.AccountRetriever)
 			return tx.GenerateOrBroadcastTxWithFactory(clientCtx, txf, msg)
 		},