Ignore multiple registration of the same delegate with the same name. (…

…#158)
dynamicexpresso · Jul 2, 2021 · 12bb256 · 12bb256
1 parent 4aabda0
commit 12bb256
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 3 deletions.
diff --git a/src/DynamicExpresso.Core/Identifier.cs b/src/DynamicExpresso.Core/Identifier.cs
@@ -1,4 +1,4 @@
-using System;
+using System;
 using System.Collections.Generic;
 using System.Linq.Expressions;
 
@@ -56,7 +56,9 @@ internal MethodGroupExpression(Delegate overload)
 
 		internal void AddOverload(Delegate overload)
 		{
-			_overloads.Add(overload);
+			// don't register the same overload twice
+			if (_overloads.IndexOf(overload) == -1)
+				_overloads.Add(overload);
 		}
 	}
 }
diff --git a/test/DynamicExpresso.UnitTest/VariablesTest.cs b/test/DynamicExpresso.UnitTest/VariablesTest.cs
@@ -1,4 +1,4 @@
-using System;
+using System;
 using NUnit.Framework;
 using System.Linq.Expressions;
 using DynamicExpresso.Exceptions;
@@ -140,6 +140,17 @@ public void Keywords_with_delegate()
 			Assert.AreEqual(9.0, target.Eval("pow(3, 2)"));
 		}
 
+		[Test]
+		public void Keywords_with_same_overload_twice()
+		{
+			Func<double, double, double> pow = (x, y) => Math.Pow(x, y);
+			var target = new Interpreter()
+									.SetFunction("pow", pow)
+									.SetFunction("pow", pow);
+
+			Assert.AreEqual(9.0, target.Eval("pow(3, 2)"));
+		}
+
 		[Test]
 		public void Keywords_with_invalid_delegate_call()
 		{