Revert changes done in #296

dynamicexpresso · Nov 16, 2024 · 1675a6d · 1675a6d
1 parent f26a4e2
commit 1675a6d
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 1 deletion.
diff --git a/src/DynamicExpresso.Core/Resolution/ExpressionUtils.cs b/src/DynamicExpresso.Core/Resolution/ExpressionUtils.cs
@@ -36,7 +36,7 @@ public static Expression PromoteExpression(Expression expr, Type type)
 					return Expression.Convert(expr, genericType);
 			}
 
-			if (TypeUtils.IsCompatibleWith(expr.Type, type) || expr is DynamicExpression)
+			if (TypeUtils.IsCompatibleWith(expr.Type, type))
 			{
 				return Expression.Convert(expr, type);
 			}

diff --git a/test/DynamicExpresso.UnitTest/GithubIssues.cs b/test/DynamicExpresso.UnitTest/GithubIssues.cs
@@ -775,6 +775,7 @@ public void GitHub_Issue_292()
 		}
 
 		[Test]
+		[Ignore("The fix suggested in #296 break other use cases, so let's ignore this test for now")]
 		public void GitHub_Issue_295()
 		{
 			var evaluator = new Interpreter();
@@ -849,6 +850,21 @@ public void GitHub_Issue_314()
 			var exception2 = Assert.Throws<UnknownIdentifierException>(() => interpreter.Eval("b > 1"));
 			Assert.AreEqual("b", exception2.Identifier);
 		}
+
+		[Test]
+		public void GitHub_Issue_325()
+		{
+			var options = InterpreterOptions.Default | InterpreterOptions.LateBindObject;
+			var interpreter = new Interpreter(options);
+
+			var input = new
+			{
+				Prop1 = 4,
+			};
+
+			var expressionDelegate = interpreter.ParseAsDelegate<Func<object, bool>>($"input.Prop1 == null", "input");
+			Assert.IsFalse(expressionDelegate(input));
+		}
 	}
 
 	internal static class GithubIssuesTestExtensionsMethods