Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(random): 🐛 random numbers type are the same as the modulo type #734

Merged
merged 4 commits into from
Oct 2, 2023
Merged

fix(random): 🐛 random numbers type are the same as the modulo type #734

merged 4 commits into from
Oct 2, 2023

Conversation

matteo-cristino
Copy link
Collaborator

No description provided.

@matteo-cristino
fix(random): 🐛 rnadom numbers type are the same as the modulo type
3fb23d8 
Hardocded numbers will be treat as integers. Also search for input data in Zenroom data (mayhave).
@matteo-cristino
test: 🧪 update test output for the new random integers
b723e62
@matteo-cristino matteo-cristino added SKIP_JS Add this label to PR for skip JS checks in CI SKIP_RUST Add this label to PR for skip RUST checks in CI SKIP_PY Add this label to PR for skip PY checks in CI SKIP_GO Add this label to PR for skip GO checks in CI labels Sep 26, 2023
@jaromil
Copy link
Member

jaromil commented Oct 2, 2023

excellent fix, tha nks!

@jaromil jaromil merged commit 8ad1cd7 into master Oct 2, 2023
23 checks passed
@jaromil jaromil deleted the fix/random branch October 2, 2023 08:38
@matteo-cristino matteo-cristino mentioned this pull request Oct 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
SKIP_GO Add this label to PR for skip GO checks in CI SKIP_JS Add this label to PR for skip JS checks in CI SKIP_PY Add this label to PR for skip PY checks in CI SKIP_RUST Add this label to PR for skip RUST checks in CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matteo-cristino @jaromil