Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kpatch-build: add support for OpenCloudOS #1372

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

anatasluo
Copy link
Contributor

OpenCloudOS is a centos-like Linux distribution.
I test kpatch in OpenCloudOS V8 and V9.
It works well in V9. But v8 itself has two problems:

  1. no available epol repo, so kpatch can't install ccache.
  2. executing 'uname -r' can't get an accurate kernel version.

Both problems have been notified to the OpenCloudOS community. After they fix these problems, kpatch will work well in all versions.

@joe-lawrence
Copy link
Contributor

Thanks for contributing @anatasluo. FYI, we have an inflight MR #1368 that is touching this very code, let's get that one finished and merged, than we can rebase this one on top.

@anatasluo
Copy link
Contributor Author

@joe-lawrence Sure, it makes code seem better.

Copy link

This PR has been open for 60 days with no activity and no assignee. It will be closed in 7 days unless a comment is added.

@anatasluo
Copy link
Contributor Author

@joe-lawrence I have adapted this patch based on #1368 . Can you please help review again ?

@joe-lawrence
Copy link
Contributor

@anatasluo : kpatch-build changes look good, but can you provide a function for test/integration/lib.sh to install the OpenCloudOS build dependencies? If these are exactly the same as RHEL, then feel free to copy the CentOS strategy of just wrapping the kpatch_rhel_dependencies() funciton.

OpenCloudOS is a centos-like Linux distribution.
I test kpatch in OpenCloudOS V8 and V9.
It works well in V9. But v8 itself has two problems:
1. no available epol repo, so kpatch can't install ccache.
2. executing 'uname -r' can't get an accurate kernel version.

Both problems have been notified to the OpenCloudOS community.
After they fix these problems, kpatch will work well in all versions.

Signed-off-by: Longjun Luo <[email protected]>
@anatasluo
Copy link
Contributor Author

@joe-lawrence Thanks for your review, I have fixed this problem. Is there anything else I should do?

@github-actions github-actions bot removed the stale label Mar 19, 2024
@joe-lawrence joe-lawrence merged commit b363972 into dynup:master Mar 26, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants