refactor: internal/helper/image_unit_test : use table driven tests #838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PapePathe
changed the title
nandor-magyar
requested changes
Oct 2, 2023
Unit tests were spread across various functions, but most of them can be organized into table driven test cases.
…ction Promot NewPTR as a general helper function .
PapePathe
force-pushed
the
test/add_table_testing_to_images_unit_test
branch
from
96d3839 to
732dcd0
Compare
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #838 +/- ##
===========================================
+ Coverage 24.29% 24.31% +0.02%
===========================================
Files 62 63 +1
Lines 5994 5996 +2
===========================================
+ Hits 1456 1458 +2
Misses 4432 4432
Partials 106 106
☔ View full report in Codecov by Sentry. |
nandor-magyar
approved these changes
Oct 8, 2023
|
One other thing is missing here, that I should've noticed earlier, we require all commits to be signed: https://github.com/dyrector-io/dyrectorio/blob/develop/CONTRIBUTING.md#commit-signatures |
chandhuDev
pushed a commit
to chandhuDev/dyrectorio
that referenced
this pull request
Nov 7, 2023
…yrector-io#838) * refactor internal/helper/image_unit_test : use table driven tests Unit tests were spread across various functions, but most of them can be organized into table driven test cases. * refactor internal/helper/image/image_unit_test.go extract utility function Promot NewPTR as a general helper function . * refactor: internal/helper/image_unit_test : add name to table tests * feat: add tests to pointer module --------- Co-authored-by: Nandor Magyar <[email protected]> Co-authored-by: Levente Orban <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #832
Unit tests were spread across various functions, but most of them can be organized into table driven test cases.