Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: inspect container #841

Merged
merged 23 commits into from
Oct 11, 2023
Merged

feat: inspect container #841

merged 23 commits into from
Oct 11, 2023

Conversation

AmorfEvo
Copy link
Contributor

@AmorfEvo AmorfEvo commented Oct 5, 2023 •
edited
Loading

  • Add container inspection functionality with json and table views.
  • Add better swagger descriptions and summaries on node prefix container controller endpoints.
  • Move all agent timeouts to shared constants.

@github-actions github-actions bot added source:agent The scope of the issue or pull request is agent. source:web The scope of the issue or pull request is web. lang:golang lang:typescript source:proto Protobuf related changes. labels Oct 5, 2023
@codecov
Copy link

codecov bot commented Oct 5, 2023 •
edited
Loading

Codecov Report

Attention: 52 lines in your changes are missing coverage. Please review.

Comparison is base (c7d2a60) 24.29% compared to head (76f8409) 24.08%.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop     #841      +/-   ##
===========================================
- Coverage    24.29%   24.08%   -0.21%     
===========================================
  Files           62       62              
  Lines         5994     6046      +52     
===========================================
  Hits          1456     1456              
- Misses        4432     4484      +52     
  Partials       106      106
Files Coverage Δ
golang/pkg/dagent/utils/docker.go 3.03% <0.00%> (-0.14%) ⬇️
golang/internal/grpc/grpc.go 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

AmorfEvo added 19 commits October 5, 2023 14:47
@AmorfEvo
feat: use prefix and name in container inspect message
8088533
@AmorfEvo
feat: agent and api call (wip)
642fa16
@AmorfEvo
feat: agent and api call
0739813
@AmorfEvo
chore: linting
07560fa
@AmorfEvo
feat: container inspection ui (wip)
a5edcc2
@AmorfEvo
feat: container inspection ui (wip)
76f8409
@AmorfEvo
Merge branch 'develop' into feat/container-inspect
e7ec04e
@AmorfEvo
chore: remove unused container identifier from container inspection dto
147b0dd
@AmorfEvo
feat: add inspect container endpoint to node global container control…
606d839 
…ler with global prefix
@AmorfEvo
doc: better descriptions and summaries on node prefix container contr…
55c030e 
…oller endpoints
@AmorfEvo
refactor: rename and move secret timeout to shared consts
f70f5a3
@AmorfEvo
refactor: distinct timeout const for inspection too
c97741e
@AmorfEvo
Merge branch 'develop' into feat/container-inspect
423535d
@AmorfEvo
feat: container inspection ui with json viewer
2e72e86
@AmorfEvo
fix: agent test and linting
2576cb3
@AmorfEvo
feat: container inspection ui table view (wip)
e57acaf
@AmorfEvo
feat: add node connection status unreachable
4e963eb
@AmorfEvo
feat: handle unknown container error
3c2af03
@AmorfEvo
feat: container inspection ui table view
93b1ae0
@codecov-commenter
Copy link

codecov-commenter commented Oct 10, 2023 •
edited
Loading

Codecov Report

Attention: 53 lines in your changes are missing coverage. Please review.

Comparison is base (de02309) 26.49% compared to head (8bec2ab) 26.27%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop     #841      +/-   ##
===========================================
- Coverage    26.49%   26.27%   -0.22%     
===========================================
  Files           70       70              
  Lines         7292     7345      +53     
===========================================
- Hits          1932     1930       -2     
- Misses        5209     5264      +55     
  Partials       151      151
Files Coverage Δ
golang/pkg/dagent/utils/docker.go 3.03% <0.00%> (-0.14%) ⬇️
golang/internal/grpc/grpc.go 0.63% <0.00%> (-0.03%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AmorfEvo AmorfEvo marked this pull request as ready for review October 10, 2023 22:09
@AmorfEvo AmorfEvo requested a review from a team as a code owner October 10, 2023 22:09
polaroi8d
polaroi8d approved these changes Oct 11, 2023
View reviewed changes
Copy link
Collaborator

@polaroi8d polaroi8d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (informal)

nandor-magyar
nandor-magyar approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@nandor-magyar nandor-magyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor eye-candy only, otherwise looks good.

golang/pkg/dagent/utils/docker.go Outdated Show resolved Hide resolved
robot9706
robot9706 requested changes Oct 11, 2023
View reviewed changes
web/crux-ui/src/pages/[teamSlug]/nodes/[nodeId]/inspect.tsx Outdated Show resolved Hide resolved
web/crux-ui/src/models/node.ts Outdated Show resolved Hide resolved
@polaroi8d polaroi8d merged commit 038f2f1 into develop Oct 11, 2023
34 of 52 checks passed
@polaroi8d polaroi8d deleted the feat/container-inspect branch October 11, 2023 13:46
chandhuDev pushed a commit to chandhuDev/dyrectorio that referenced this pull request Nov 7, 2023
@AmorfEvo @chandhuDev
feat: inspect container (dyrector-io#841)
70447a3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nandor-magyar nandor-magyar nandor-magyar approved these changes

@polaroi8d polaroi8d polaroi8d approved these changes

@robot9706 robot9706 robot9706 approved these changes

Assignees

@AmorfEvo AmorfEvo

Labels
lang:golang lang:javascript lang:typescript pr:feat source:agent The scope of the issue or pull request is agent. source:proto Protobuf related changes. source:web The scope of the issue or pull request is web.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AmorfEvo @codecov-commenter @robot9706 @polaroi8d @nandor-magyar