Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(agent): add capital image name handling #848

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

nandor-magyar
Copy link
Contributor

We found that on GitHub the organization can have uppercase letters, but the images on ghcr.io will not have uppercase, as per standards.
Specs.

@nandor-magyar nandor-magyar requested a review from a team as a code owner October 10, 2023 08:51
@codecov-commenter
Copy link

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (6205fa0) 26.44% compared to head (2d5adcc) 26.46%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #848      +/-   ##
===========================================
+ Coverage    26.44%   26.46%   +0.02%     
===========================================
  Files           70       70              
  Lines         7290     7292       +2     
===========================================
+ Hits          1928     1930       +2     
  Misses        5211     5211              
  Partials       151      151              
Files Coverage Δ
golang/internal/helper/image/image.go 64.46% <100.00%> (+0.26%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@polaroi8d polaroi8d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@polaroi8d polaroi8d merged commit de02309 into develop Oct 10, 2023
26 checks passed
@polaroi8d polaroi8d deleted the fix/agent-capital-image-handling branch October 10, 2023 10:12
chandhuDev pushed a commit to chandhuDev/dyrectorio that referenced this pull request Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants