Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installer for release versions #185

Merged
merged 6 commits into from
Feb 1, 2024
Merged

Conversation

BenediktMKuehne
Copy link
Member

@BenediktMKuehne BenediktMKuehne commented Dec 19, 2023

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • adds EMBA installation option without git

What is the current behavior? (You can also link to an open issue here)

installer relies on exclusively git functions for some stuff

What is the new behavior (if this is a feature change)? If possible add a screenshot.

Installation should work from tarball/zip release

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

nope

Other information:

#180
#181

@BenediktMKuehne BenediktMKuehne marked this pull request as ready for review December 21, 2023 07:04
Copy link
Member

@m-1-k-3 m-1-k-3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for the delay ... I have missed this PR

installer.sh Outdated Show resolved Hide resolved
installer.sh Outdated Show resolved Hide resolved
Copy link
Member

@HoxhaEndri HoxhaEndri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the installation and everything works fine. Just add the quotations like Mike wrote.

@m-1-k-3 m-1-k-3 merged commit 66843db into e-m-b-a:main Feb 1, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants