Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor market keeper #135

Closed
haasted opened this issue Sep 14, 2021 · 0 comments · Fixed by #150
Closed

Refactor market keeper #135

haasted opened this issue Sep 14, 2021 · 0 comments · Fixed by #150

Comments

@haasted
Copy link
Collaborator

haasted commented Sep 14, 2021 •
edited
Loading

Most methods in the market keeper currently returns the touple (*sdk.Result, error). The *sdk.Result is mostly used to return events that are already present in the context. This results in the occasional duplication of events being emitted (#130).

Refactor the market keeper to only return an error and any values that may already be present, and let the msg_server handle extraction of events from the context object.
@blewater blewater mentioned this issue Sep 22, 2021
Closed
@blewater blewater linked a pull request Sep 22, 2021 that will close this issue
135 Market error #142
Closed
This was referenced Sep 27, 2021
Closed
Merged
@mergify mergify bot closed this as completed in #150 Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor market keeper against master e-money/em-ledger
135 Market error e-money/em-ledger
1 participant
@haasted