Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Market keeper refactoring, events validation #149

Closed
wants to merge 11 commits into from
Closed

Market keeper refactoring, events validation #149

wants to merge 11 commits into from

Conversation

blewater
Copy link
Contributor

  • Closes #135 remove the returned sdk.Result from the Keeper API.
  • Sets the context's event manager to return events.
  • Added missing error descriptions.
  • Added add-market, cancelreplace order type bdd tests.
  • Added bdd test market order event validation.

@blewater blewater requested a review from haasted September 27, 2021 11:32
@blewater
Copy link
Contributor Author

Closing to send against master as github does not support changing the target branch on an open PR.

@blewater blewater closed this Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haasted haasted Awaiting requested review from haasted

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blewater @mdyring