changing to swift 4 apis and semantics

[mbalex99]

changing to swift 4 apis and semantics
The UI is a tiny bit wonky. I could use some help fixing stuff :-)
Update Thanks to @artanisdesign and @austinzheng for all the tiny fixes that totally eluded me!

So if you want Swift 4 today. You can install it like so:

pod 'NMessenger', :git => 'https://github.com/mbalex99/NMessenger', :branch => 'swift4'

[mbalex99]

Thanks so much @austinzheng for fixing ContentNodes an amazing. Job I would have never found it without his changes.

He was kind enough to give me the proper diffs to help me fix this.

This is ready for you guys to use it looks like! And certainly ready for a review!

[gorbat-o]

hey, it should be merge one day :)

[mbalex99]

There’s a problem where one of the cells doesn’t have the right height. You should checkout this branch and give it a run to see the issue

On Sat, Nov 25, 2017 at 2:22 PM Oleg Gorbatchev ***@***.***> wrote: hey, it should be merge one day :) — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#161 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACFSMcSwKXbwnaSPljGYUYp6R-pKrY12ks5s6K9fgaJpZM4PsvfW> .

-- Maximilian Alexander [email protected] www.maxofeden.com

[p1n0-0]

I have verified that grouped messages are not displayed when sent. The first load works fine, but when you send several consecutive messages they do not get to show.

You can check it with the MessagesGroup example.

[artanisdesign]

Any idea how to fix that UI glitch? i guess this is happened because of the Texture (ASDK) update.. and i found this in the MessageGroup class

[artanisdesign]

Well, it seems adding
self.setNeedsLayout()
to line 201 solved the problem, PR in on @mbalex99 fork

[mbalex99]

@artanisdesign I added it and that did the trick 🎊 . Committed and pushed!

[jacobokoenig]

Hey.. that pod says "Alamofire".. Mistake?

[mbalex99]

@jacobo360 fixed. Thank you

[tyronegroves]

Will this be merged into the main code base?

[dodikk]

So if you want Swift 4 today. You can install it like so:

Instructions for Carthage

github "mbalex99/NMessenger" "swift4"

[dodikk]

Why no version here? The .podspec has it.

s.dependency "Texture", "2.5"

[dodikk]

Any idea "whose dependency is LoremIpsum.framework" ?

[dodikk]

Will this be merged into the main code base?

@tyronegroves , unfortunately, eBay takes actions really slowly. From time to time I start thinking they have abandoned this project ((
See this thread for details #149

P.S. Then one of them writes a comment. And again - the silence for months.

[dodikk]

Will this be merged into the main code base?

Actually, we can just switch to the "mbalex99/NMessenger" repo, merge all PRs from this one there, etc. In other words, an independent fork should be a way to go if there were a volonteer maintainer.

[tyronegroves]

Well I will try to find something else