Skip to content
This repository has been archived by the owner on Aug 1, 2019. It is now read-only.

[unstable] Optimized "to past" scrolling by reversing cells order #179

Open
wants to merge 42 commits into
base: master
Choose a base branch
from
Open

[unstable] Optimized "to past" scrolling by reversing cells order #179

wants to merge 42 commits into from

Conversation

dodikk
Copy link

@dodikk dodikk commented Dec 12, 2017

  • Optimized "to past" scrolling by reversing cells order
  • it is hard-coded yet
  • swift4 support and compiler error fixes

Alexander Dodatko added 30 commits April 24, 2017 11:02
more brief rect constant
4eb5bd5
[128] custom nib for bottom bar
9a65c71
[115] avatar on top of bubble
f910a51
[122] keyboard in TabBar fix
40b541e
minor refactoring
3ac432f
minor refactoring
78ba439
[image multiselect] added a protocol for image picker VC
8dd6195
[image multiselect] added methods to override for multiselection hand…
ad4b2f6 
…ling
[image multiselect] replaced inline sendText() instructions with dele…
18dd3f2 
…gation to NMessengerController
[image multiselect] made cameraAuthStatus and photoLibAuthStatus …
53f360f 
…readonly
[multiselect] added images for multiselection and camera button
00dd63f
added a missing include
0450bd8
[multiselect] added custom picker based on UICollectionView
4c9103d
[multiselect] encapsulated push/pop for image picker
655ed35
Minor refactoring. Also added a todo about localization.
f8cbc1b
[multiselect] separate directory for picker
233308b
[multiselect] added camera image
6d40c20
[multiselect] extracted "image from picker response" helper class
479e53e
[multiselect] added live camera cell
df1b58b
[multiselect] saving newly shot image in camera roll
e86a83b
[multiselect] extended customization options
7fa86f6 
TODO: maybe replace a struct with a protocol/delegate
[multiselect] added some properties to accomplish the feature
957b39d
[image multiselection] applied lazy to PHCachingImageManager to avoid…
90e30b6 
… an unwanted system permission dialog
added an optional symbols count limit
446e8d2
[eBay#142] extracted itemsCount property to fix the crash
97cc2f8 
Merged eBay#145
[refactoring] extracted a few local variables
1b947ac
Added "symbolsCounterLabel" and some text input limitations logic
b0f83b8 
* Added "symbolsCounterLabel"
* Unwrapped `checkCameraPermissions` and `checkPhotoLibraryPermissions`
as explicit boolean table with pattern matching
* Added `pickedImageAssets` delegate method for multiselection
[eBay#143] Extracted CameraViewDelegate to a separate class
27adb9f
[eBay#143] added "text + collection" subclass of CollectionViewConten…
8430b3a 
…tNode
[crash] fixed photo capture issue by replacing force unwrap with `if …
74722aa 
…let`
Alexander Dodatko added 12 commits July 20, 2017 18:31
[eBay#143] added PHAssets delegate methods for multiselect picker
6a355a3 
also using `defer` keyrowd for safer `imageListGuard.unlock`
[eBay#143] added PHAsset getter to MultiselectImagePickerController
8d45b77
[eBay#143] added func onAssetsPicked() to override
e6db74f
swift4 support fixes
675cd8f
[timestamp] added mixed content node and timestamp utils class
51edfb7
[image] extracted aspect ratio constant to a local variable
c8a5c83
[alerts] added localization for menu entries
d48b0df
swift4 support fixes
bc26014
[image picker] added more delegate methods for better flexibility
2e2c550
swift4 support fixes
864fc12
[optimization] reverse cell order for sooth "scroll backwards" scenario
d20d642
[NMessengerViewController] exposed some constraints for injection pri…
693287c 
…or to super.viewDidLoad call
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dodikk