docs: storybook sync up with event arguments #1977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saiponnada
force-pushed
the
storybook-fixes
branch
from
6956707
to
36753c7
Compare
saiponnada
changed the title
LuLaValva
approved these changes
Sep 8, 2023
| el, | ||
| originalEvent, | ||
| index, | ||
| }; | ||
| eventObj = Object.entries(eventObj) |
There was a problem hiding this comment.
If you'd like you can use Object.fromEntries here instead of reduce. I think it's a little cleaner but it is personal preference.
There was a problem hiding this comment.
I like it. Looks cleaner. Rolled out the change.
agliga
approved these changes
Sep 11, 2023
LuLaValva
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated storybook documentation to sync up with the component events. Both DOM and component events are being emitted and storybook displays these events in actions tab. During this process for some component events, marko class information is being emitted. We decided to leave that extra information as is. Other-than that, the callback arguments were appropriately corrected in the storybook documentation.
References
Fixes following
#1930
#1892
#1887
#1890
Screenshots
Page/Section notice
Fake menu button
Confirm dialog
Drawer dialog
