Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(date-textbox, calendar): clear behavior with ranges #2296

Merged
merged 3 commits into from
Oct 18, 2024

Conversation

LuLaValva
Copy link
Member

Description

  • Allow clearing date textbox with range
  • Updated example to work with the changes. This makes the example more complicated, it may even be better to keep the simpler version even though it doesn't work when you toggle range to true.
  • This uncovered a bug in ebay-calendar with clearing of dates, which I fixed

@LuLaValva LuLaValva requested a review from agliga October 17, 2024 20:21
@LuLaValva LuLaValva self-assigned this Oct 17, 2024
Copy link

changeset-bot bot commented Oct 17, 2024

🦋 Changeset detected

Latest commit: a59e3de

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ebay/ebayui-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes the example a little complicated, what do you think about leaving as-is and adding a comment instead that says this naive implementation won't work with range?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, what makes them complicated. Not sure I follow

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It just makes the example a little longer since it has to handle both cases. There will realistically never be an app that needs to handle both range and single select in the same spot.

@LuLaValva LuLaValva merged commit e2d2829 into 14.4.0 Oct 18, 2024
4 checks passed
@LuLaValva LuLaValva deleted the 2295-date-textbox-rangeEnd branch October 18, 2024 19:22
@github-actions github-actions bot mentioned this pull request Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants