Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added async loading support #2321

Open
wants to merge 4 commits into
base: 14.5.0
Choose a base branch
from
Open

feat: added async loading support #2321

wants to merge 4 commits into from

Conversation

agliga
Copy link
Contributor

@agliga agliga commented Nov 11, 2024

Description

  • In order to make it so we dont upload compiled files to the CDN I changed the loading portion of our modules to load modules asynchronously.
  • Changed model-viewer, highcharts, and shaka-player to load asynchronously.
  • The changes to package.json, and prettier are needed because we introduced a nested node_modules directory

Context

  • Part of the issue is we need to support lasso and webpack async. These load modules asynchronously very differently.
  • We added a "fake" node_module directory where we load a module using import() if its vite or webpack, but if its lasso we load it using lassoLoader
  • The reason why there are multiple modules is mainly for bundling purposes. These will all be indexed properly.
  • These also need to be tested in a prerelase to verify that this is working fine is all various types of apps.

note I had to disable a highcharts test because it was not finding the text correctly.

References

#2305

Copy link

changeset-bot bot commented Nov 11, 2024

🦋 Changeset detected

Latest commit: 98f6fca

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ebay/ebayui-core Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mikehobi
Copy link
Contributor

@agliga quick glance at it, looks like pattern-fill is not working properly

image

@agliga
Copy link
Contributor Author

agliga commented Nov 15, 2024

@agliga quick glance at it, looks like pattern-fill is not working properly

image

What would cause this problem?

@mikehobi
Copy link
Contributor

mikehobi commented Nov 15, 2024

@agliga quick glance at it, looks like pattern-fill is not working properly
image

What would cause this problem?

I think accessibility and pattern fill need to be initialized

Something like this might work:

        highChartsLoad()
            .then(([highcharts, accessibility, patternFill]: any) => {
                window.Highcharts = highcharts.default;

                accessibility.default(window.Highcharts);

                patternFill.default(window.Highcharts);

                this.handleSuccess();
            })
            .catch((e: Error) => {
                this.handleError(e);
            });

@agliga
Copy link
Contributor Author

agliga commented Nov 20, 2024

Should be good to go. Fixed mikes issue
Also the license thing is probably due to highcharts being a depdency now. I will ignore this since this is documented properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants