Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ccd): added new component #2327

Merged
merged 2 commits into from
Nov 22, 2024
Merged

feat(ccd): added new component #2327

merged 2 commits into from
Nov 22, 2024

Conversation

agliga
Copy link
Contributor

@agliga agliga commented Nov 18, 2024

Description

  • Added CCD component

Context

  • We need to toggle between one and two figures in this. Added some boolean types to allow toggling

References

#2326

@agliga agliga self-assigned this Nov 18, 2024
Copy link

changeset-bot bot commented Nov 18, 2024

🦋 Changeset detected

Latest commit: 75c512f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ebay/ebayui-core Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@agliga
Copy link
Contributor Author

agliga commented Nov 21, 2024

Test is failing because we havent linked up skin. Should pass once we have the correct skin version.

Copy link
Contributor

@ArtBlue ArtBlue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@LuLaValva LuLaValva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor comments

src/components/ebay-ccd/index.marko Outdated Show resolved Hide resolved
src/components/ebay-ccd/index.marko Outdated Show resolved Hide resolved
@ArtBlue ArtBlue merged commit 30b5859 into 14.5.0 Nov 22, 2024
4 of 5 checks passed
@ArtBlue ArtBlue deleted the ccd branch November 22, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants