Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(filter-menu): add header with search #2330

Merged
merged 7 commits into from
Nov 22, 2024
Merged

feat(filter-menu): add header with search #2330

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
86b4290
feat(filter-menu): search header
LuLaValva Nov 19, 2024
af71cf8
feat(filter-menu-button): search header
LuLaValva Nov 19, 2024
3ba07a8
chore: add changeset
LuLaValva Nov 19, 2024
7081673
chore: update tests
LuLaValva Nov 19, 2024
1b9b43c
fix(filter-menu): use ebay-button
LuLaValva Nov 19, 2024
495147f
fix(examples): preserve search results
LuLaValva Nov 20, 2024
e92122a
feat(filter-menu): allow search value override
LuLaValva Nov 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/famous-peas-own.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@ebay/ebayui-core": minor
---

Search header for filter menu & filter menu button
3 changes: 3 additions & 0 deletions src/components/ebay-filter-menu-button/component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,14 @@ interface FilterMenuButtonInput
"form-method"?: string;
disabled?: boolean;
"a11y-text"?: AttrString;
"search-header-placeholder-text"?: string;
"a11y-search-header-clear-text"?: string;
"on-expand"?: () => void;
"on-change"?: (event: FilterMenuButtonEvent) => void;
"on-collapse"?: (event: FilterMenuButtonEvent) => void;
"on-footer-click"?: (event: FilterMenuButtonEvent) => void;
"on-form-submit"?: (event: FilterMenuButtonEvent) => void;
"on-search-change"?: (value: string) => void;
}

export interface Input extends WithNormalizedProps<FilterMenuButtonInput> {}
Expand Down
Loading
Loading