🎨 Simplify structure of base Android classes

The explicitly created constructors are replaced one constructor with default value of parameter. The constructor has @jvmoverloads annotation to maintain Java interoperability.
eManPrague · Apr 1, 2020 · b2b2183 · b2b2183
1 parent 5f1224b
commit b2b2183
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 10 deletions.
diff --git a/kaal-presentation/src/main/kotlin/cz/eman/kaal/presentation/activity/BaseActivity.kt b/kaal-presentation/src/main/kotlin/cz/eman/kaal/presentation/activity/BaseActivity.kt
@@ -12,14 +12,12 @@ import kotlinx.coroutines.cancel
  * @see[AppCompatActivity]
  * @since 0.1.0
  */
-abstract class BaseActivity : AppCompatActivity, CoroutineScope {
+abstract class BaseActivity @JvmOverloads constructor(
+    @LayoutRes contentLayoutId: Int = 0
+) : AppCompatActivity(contentLayoutId), CoroutineScope {
 
     override val coroutineContext = Dispatchers.Main + SupervisorJob()
 
-    constructor(): super()
-
-    constructor(@LayoutRes contentLayoutId: Int): super(contentLayoutId)
-
     override fun onDestroy() {
         super.onDestroy()
         coroutineContext.cancel()

diff --git a/kaal-presentation/src/main/kotlin/cz/eman/kaal/presentation/fragment/BaseFragment.kt b/kaal-presentation/src/main/kotlin/cz/eman/kaal/presentation/fragment/BaseFragment.kt
@@ -12,14 +12,12 @@ import kotlinx.coroutines.cancel
  * @see[Fragment]
  * @since 0.1.0
  */
-abstract class BaseFragment : Fragment, CoroutineScope {
+abstract class BaseFragment @JvmOverloads constructor(
+    @LayoutRes contentLayoutId: Int = 0
+) : Fragment(contentLayoutId), CoroutineScope {
 
     override val coroutineContext = Dispatchers.Main + SupervisorJob()
 
-    constructor(): super()
-
-    constructor(@LayoutRes contentLayoutId: Int): super(contentLayoutId)
-
     override fun onDestroy() {
         super.onDestroy()
         coroutineContext.cancel()