Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/gtl visualization #215

Merged
merged 3 commits into from
May 6, 2024
Merged

Conversation

arg0n1s
Copy link
Contributor

@arg0n1s arg0n1s commented May 3, 2024

Introduced some fixes to provide a basic graphical visualization of GT rules and patterns.
Note: Some advanced features are still missing (e.g., attribute conditions, injectivity constraints, parameters).

arg0n1s added 2 commits May 3, 2024 14:32
+ Todo: fix some minor visualization errors
++ visualize patterns
++ visualize rules
++ visualize invocations
++ visualize invocation node mappings

TODO: Think about the following Features:
+ How to visualize parameters?
+ How to visualize injectivity constraints?
+ How to visualize attribute conditions?
+ How to visualize attribute assignments?
@arg0n1s arg0n1s requested review from Arikae and maxkratz May 3, 2024 14:39
@maxkratz maxkratz force-pushed the hotfix/gtl_visualization branch from f1b6dc8 to 7a0b2ba Compare May 3, 2024 15:16
@maxkratz
Copy link
Member

maxkratz commented May 3, 2024

I've fixed the plugin.xml_gen files (removed them + added these files to the gitignore).

@maxkratz
Copy link
Member

maxkratz commented May 3, 2024

I found that the visualization of more complex patterns/rules does not contain the same information as in the respective IBeX v1 tests. See for example the test case ClassMultipleInheritance-GT, pattern pattern findClassByQualifiedName(packageName: EString, className: EString) refines findClass below.

If I understand it correctly, attribute constraints and parameters are missing. Do we plan to visualize them (so this is kind of a bug) or do we just want a simpler visualization (as it is right now)?


IBeX 1:
Screenshot from 2024-05-03 17-25-21

IBeX 2:
Screenshot from 2024-05-03 17-25-12

@maxkratz
Copy link
Member

maxkratz commented May 3, 2024

I found that the visualization of more complex patterns/rules does not contain the same information as in the respective IBeX v1 tests. See for example the test case ClassMultipleInheritance-GT, pattern pattern findClassByQualifiedName(packageName: EString, className: EString) refines findClass below.

If I understand it correctly, attribute constraints and parameters are missing. Do we plan to visualize them (so this is kind of a bug) or do we just want a simpler visualization (as it is right now)?

I misread the PR description, sorry. I suggest we merge this PR and open an issue after merging the whole IBeX v2 branches (see eMoflon/emoflon-ibex#424) to support the more advanced visualizations (like attribute constraints, etc.).

Copy link
Member

@maxkratz maxkratz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I wrote in my previous comment, I'm fine with merging this PR.

@maxkratz maxkratz merged commit 7211276 into rework_TGG_validatorfix May 6, 2024
@maxkratz maxkratz deleted the hotfix/gtl_visualization branch May 6, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants