-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hotfix/gtl visualization #215
Conversation
+ Todo: fix some minor visualization errors
++ visualize patterns ++ visualize rules ++ visualize invocations ++ visualize invocation node mappings TODO: Think about the following Features: + How to visualize parameters? + How to visualize injectivity constraints? + How to visualize attribute conditions? + How to visualize attribute assignments?
f1b6dc8
to
7a0b2ba
Compare
I've fixed the |
I found that the visualization of more complex patterns/rules does not contain the same information as in the respective IBeX v1 tests. See for example the test case If I understand it correctly, attribute constraints and parameters are missing. Do we plan to visualize them (so this is kind of a bug) or do we just want a simpler visualization (as it is right now)? |
I misread the PR description, sorry. I suggest we merge this PR and open an issue after merging the whole IBeX v2 branches (see eMoflon/emoflon-ibex#424) to support the more advanced visualizations (like attribute constraints, etc.). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I wrote in my previous comment, I'm fine with merging this PR.
Introduced some fixes to provide a basic graphical visualization of GT rules and patterns.
Note: Some advanced features are still missing (e.g., attribute conditions, injectivity constraints, parameters).