Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add case3_MARRMOT_calibration_ensemble_RunSavanah notebook #16

Merged
merged 11 commits into from
Aug 23, 2021

Conversation

SarahAlidoost
Copy link
Contributor

@SarahAlidoost SarahAlidoost commented Jun 24, 2021

To create ewatercycle conda environment, see eWaterCycle/ewatercycle#234

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@SarahAlidoost SarahAlidoost marked this pull request as ready for review August 10, 2021 07:32
@sverhoeven sverhoeven self-requested a review August 12, 2021 14:07
@sverhoeven
Copy link
Member

I submitted the nb on cartesius.
After creation of ewatercycle conda env I also had to install cma and jupyter.
I also had to copy ~/.config/ewatercycle/ewatercycle.yaml .

Currently seeing load of 13 (out of 24), so I think the popsize can be increased to 18 if we want to.

@sverhoeven
Copy link
Member

Job completed OK
CPU Utilized: 1-14:50:34
CPU Efficiency: 45.960f 3-12:30:48 core-walltime
Job Wall-clock time: 03:31:17

Copy link
Member

@sverhoeven sverhoeven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, I got the same result. I like the amount of docs.

See nbreview comments for questions/suggestions.

@SarahAlidoost
Copy link
Contributor Author

Great, I got the same result. I like the amount of docs.

See nbreview comments for questions/suggestions.

Many thanks for reviewing, your comments are addressed. Please have another look.

@sverhoeven
Copy link
Member

I submitted the notebook again to check the log messages.

@sverhoeven
Copy link
Member

Hmm, got error

PermissionError                           Traceback (most recent call last)
/scratch-local/verhoes.10667541/ipykernel_8631/1173285456.py in <module>
      2 filename = f"{CFG['output_dir']}/marrmot-m14_ERA5_Savannah_calibration_{CALIBRATION['start']}_{CALIBRATION['end']}.yml"
      3 filename = "/scratch/shared/ewatercycle/case3_marrmot14/marrmot-m14_ERA5_Savannah_calibration_1991-01-01T00:00:00Z_2001-12-31T00:00:00Z.yml"
----> 4 with open(filename) as f:
      5     calibration_results = yaml.load(f)
      6 fig = plot_parameters(calibration_results)

PermissionError: [Errno 13] Permission denied: '/scratch/shared/ewatercycle/case3_marrmot14/marrmot-m14_ERA5_Savannah_calibration_1991-01-01T00:00:00Z_2001-12-31T00:00:00Z.yml'

Did you remove /scratch/shared/ewatercycle/case3_marrmot14?

@SarahAlidoost
Copy link
Contributor Author

Hmm, got error

PermissionError                           Traceback (most recent call last)
/scratch-local/verhoes.10667541/ipykernel_8631/1173285456.py in <module>
      2 filename = f"{CFG['output_dir']}/marrmot-m14_ERA5_Savannah_calibration_{CALIBRATION['start']}_{CALIBRATION['end']}.yml"
      3 filename = "/scratch/shared/ewatercycle/case3_marrmot14/marrmot-m14_ERA5_Savannah_calibration_1991-01-01T00:00:00Z_2001-12-31T00:00:00Z.yml"
----> 4 with open(filename) as f:
      5     calibration_results = yaml.load(f)
      6 fig = plot_parameters(calibration_results)

PermissionError: [Errno 13] Permission denied: '/scratch/shared/ewatercycle/case3_marrmot14/marrmot-m14_ERA5_Savannah_calibration_1991-01-01T00:00:00Z_2001-12-31T00:00:00Z.yml'

Did you remove /scratch/shared/ewatercycle/case3_marrmot14?

No, the group permission wasn't set. Now it should work.

@sverhoeven
Copy link
Member

sverhoeven commented Aug 18, 2021

Job completed OK.
CPU Utilized: 1-14:50:22
CPU Efficiency: 45.820f 3-12:46:24 core-walltime
Job Wall-clock time: 03:31:56
Memory Utilized: 2.66 GB
Memory Efficiency: 4.420f 60.31 GB

The ESMValToolDeprecationWarning are not being silenced because ewatercycle import is done before filterwarnings. Can you move logging/warnings block above the imports?

Also the container log messages still appear. I think its because message is printed using root logger see eWaterCycle/grpc4bmi#103 . To silence the container message I had to set the global level to WARNING with

import logging
logging.basicConfig(level=logging.WARNING)

Can you replace existing logging code with this?

@SarahAlidoost
Copy link
Contributor Author

SarahAlidoost commented Aug 18, 2021

Job completed OK.
The ESMValToolDeprecationWarning are not being silenced because ewatercycle import is done before filterwarnings. Can you move logging/warnings block above the imports?

Also the container log messages still appear. I think its because message is printed using root logger see eWaterCycle/grpc4bmi#103 . To silence the container message I had to set the global level to WARNING with

import logging
logging.basicConfig(level=logging.WARNING)

Can you replace existing logging code with this?

Thanks @sverhoeven. I fixed the loggers. Also, I added two variables "POPSIZE" and "MAXITER", please see my last commit.

@sverhoeven
Copy link
Member

Thanks for exposing POPSIZE and MAXITER,
I submitted nb with POPSIZE=18 and commented out hardcoded filename in last cell.

Copy link
Member

@sverhoeven sverhoeven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Output cells look very silent now.

I copied my completed notebook, slurm log, output fles to /scratch/shared/ewatercycle/case3_marrmot14/byverhoes/

@SarahAlidoost
Copy link
Contributor Author

Thanks for exposing POPSIZE and MAXITER,
I submitted nb with POPSIZE=18 and commented out hardcoded filename in last cell.

Many thanks for reviewing and testing the notebook.

@SarahAlidoost SarahAlidoost merged commit 728e81b into main Aug 23, 2021
@SarahAlidoost SarahAlidoost deleted the add_case3_notebook branch August 23, 2021 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants