Performance improvement: ~13% faster on ESP32 and ~21% faster on ESP8266 (empirically tested) #554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 16, 2022 10:13
- new tsf_note_on_fast returning playIndex and removing lowpass filter setup since it is not being processed in tsf_voice_render_fast anyway but is consuming a lot of cpu - new tsf_note_off_fast using playIndex to stop voices faster - Removing lowpass filter setup from tsf_voice_render_fast since it is not being processed - Math tweaks trying to avoid complex math operations (specially conversions) at voice render stage - Precalculating *F32P32 values to avoid doing them at voice render stage
Gifford47
approved these changes
Nov 11, 2022
hackerceo
pushed a commit
to hackerceo/ESP8266Audio
that referenced
this pull request
Nov 1, 2024
…266 (empirically tested) (earlephilhower#554) * Performance improvement - new tsf_note_on_fast returning playIndex and removing lowpass filter setup since it is not being processed in tsf_voice_render_fast anyway but is consuming a lot of cpu - new tsf_note_off_fast using playIndex to stop voices faster - Removing lowpass filter setup from tsf_voice_render_fast since it is not being processed - Math tweaks trying to avoid complex math operations (specially conversions) at voice render stage - Precalculating *F32P32 values to avoid doing them at voice render stage * Fixing data type * Initializing play indexes --------- Co-authored-by: Edgar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please consider this PR trying to improve performance with these changes: