Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix site_id parameter in delete sites route #45

Closed
wants to merge 1 commit into from
Closed

Conversation

tmcw
Copy link
Contributor

@tmcw tmcw commented Aug 27, 2021

Fixes #43 - grabs the {site_id} parameter from a URL segment rather than a query parameter.

Note - please test, I don't have a fully set-up Go environment 🙈

@tmcw tmcw requested a review from tingold August 27, 2021 19:53
@tingold tingold closed this Oct 28, 2021
@tingold
Copy link
Collaborator

tingold commented Oct 28, 2021

this has migrated to plastics-api so closing here -- think it's fixed regardless

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete site by ID method tries to get the site_id from a query parameter rather than a parameter in the path
2 participants