Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests and method for list in describe_distribution #105
Add tests and method for list in describe_distribution #105
Changes from 9 commits
8b17b5a
e09702a
eab7ab2
d76719c
91f52f8
6c826fb
d82ff46
4e74d59
ca1ce91
abc4811
f2977ef
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you tried the plotting method in
{see}
and checked if it works with outputs fromlist
input?Maybe you can post an example in the PR thread.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't know there was a plotting method for that. I just tried
plot(describe_distribution(list(mtcars$mpg, mtcars$cyl)))
and it doesn't work. I don't have any experience withggplot2
programming so not sure how to handle this. I'll take a look atsee
source code later, maybe it's easier than I thinkThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can leave this in for now and create an issue in
{see}
repository so that we don't forget about it.Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.