Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better ncp ci optimization #629

Merged
merged 3 commits into from
Jan 29, 2024
Merged

Better ncp ci optimization #629

merged 3 commits into from
Jan 29, 2024

Conversation

mattansb
Copy link
Member

@mattansb mattansb commented Jan 25, 2024

Fixes #628

Also related to #367

Copy link

codecov bot commented Jan 25, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (c3be95d) 90.76% compared to head (048f0ba) 90.71%.

Files Patch % Lines
R/utils_ci.R 84.61% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #629      +/-   ##
==========================================
- Coverage   90.76%   90.71%   -0.06%     
==========================================
  Files          57       57              
  Lines        3562     3563       +1     
==========================================
- Hits         3233     3232       -1     
- Misses        329      331       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mattansb mattansb merged commit af6dfba into main Jan 29, 2024
24 of 28 checks passed
@mattansb mattansb deleted the better-ci branch January 29, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CIs in phi() function show jitter when ci approaches 1.
1 participant