format_value() should consider "options(OutDec=',')" for separator fo…

…rmatting (#957)

Fixes #193

NEWS.md

@@ -28,6 +28,9 @@
 * `export_table()` can now split tables into more than three tables when
   `table_width` is used (formerly, the maximum number of split tables was three).
 
+* `format_value()` gains a `decimal_point` argument, to change the decimal point
+  in output conversion.
+
 ## Bug fix
 
 * `clean_parameters()` now uses the correct labels for the random effects

R/format_value.R

@@ -34,6 +34,8 @@
 #' @param style_negative  A string that determines the style of negative numbers.
 #'   May be `"hyphen"` (default), `"minus"` for a proper Unicode minus symbol or
 #'   `"parens"` to wrap the number in parentheses.
+#' @param decimal_point Character string containing a single character that
+#'   is used as decimal point in output conversions.
 #' @param ... Arguments passed to or from other methods.
 #'
 #'
@@ -49,6 +51,7 @@
 #' format_value(c(0.0045, 0.12, 0.34), digits = "scientific")
 #' format_value(c(0.0045, 0.12, 0.34), digits = "scientific2")
 #' format_value(c(0.045, 0.12, 0.34), lead_zero = FALSE)
+#' format_value(c(0.0045, 0.12, 0.34), decimal_point = ",")
 #'
 #' # default
 #' format_value(c(0.0045, 0.123, 0.345))
@@ -80,6 +83,7 @@ format_value.data.frame <- function(x,
                                     lead_zero = TRUE,
                                     style_positive = "none",
                                     style_negative = "hyphen",
+                                    decimal_point = getOption("OutDec"),
                                     ...) {
   as.data.frame(sapply(
     x,
@@ -93,6 +97,7 @@ format_value.data.frame <- function(x,
     lead_zero = lead_zero,
     style_positive = style_positive,
     style_negative = style_negative,
+    decimal_point = decimal_point,
     simplify = FALSE
   ))
 }
@@ -110,6 +115,7 @@ format_value.numeric <- function(x,
                                  lead_zero = TRUE,
                                  style_positive = "none",
                                  style_negative = "hyphen",
+                                 decimal_point = getOption("OutDec"),
                                  ...) {
   # check input
   style_positive <- validate_argument(style_positive, c("none", "plus", "space"))
@@ -167,6 +173,11 @@ format_value.numeric <- function(x,
     } else if (style_negative == "parens") {
       out[negatives] <- gsub("-(.*)", "\\(\\1\\)", out[negatives])
     }
+
+    # decimal points
+    if (!is.null(decimal_point) && !identical(decimal_point, ".")) {
+      out <- gsub(".", decimal_point, out, fixed = TRUE)
+    }
   }
 
   out

tests/testthat/test-format.R

@@ -4,13 +4,15 @@ test_that("format_value", {
   expect_identical(format_value(4.0, protect_integers = TRUE), "4")
   expect_identical(format_value(0, protect_integers = TRUE), "0")
   expect_identical(format_value(0), "0.00")
+  expect_identical(format_value(0, decimal_point = ","), "0,00")
   expect_identical(format_value(1234565789101112), "1.23e+15")
   expect_identical(format_value(1234565789101112, protect_integers = TRUE), "1234565789101112")
   expect_identical(format_value(0.0000000123), "1.23e-08")
   expect_identical(format_value(0.0000000123, zap_small = TRUE), "0.00")
   expect_identical(format_value(0.0000000123, digits = 8), "0.00000001")
   expect_identical(format_value(c(0.012, 0.45, -0.03), lead_zero = FALSE), c(".01", ".45", "-.03"))
   expect_identical(format_value(c(1.012, 0.45, -0.03), lead_zero = FALSE), c("1.01", ".45", "-.03"))
+  expect_identical(format_value(c(1.012, 0.45, -0.03), lead_zero = FALSE, decimal_point = ","), c("1,01", ",45", "-,03"))
   expect_identical(format_value(c(0.45, -0.03), style_positive = "plus"), c("+0.45", "-0.03"))
   expect_identical(format_value(c(0.45, -0.03), style_positive = "plus", lead_zero = FALSE), c("+.45", "-.03"))
   expect_equal(