Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests failing in random order (again) #758

Merged
merged 6 commits into from
Sep 18, 2023
Merged

Conversation

strengejacke
Copy link
Member

Fixes #757

@etiennebacher
Copy link
Member

I can't reproduce the test-format_table.R error on Windows and there's no error message so no idea where it comes from

@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Merging #758 (70a9ee5) into main (6e78a4b) will not change coverage.
The diff coverage is n/a.

❗ Current head 70a9ee5 differs from pull request most recent head cca5f1a. Consider uploading reports for the commit cca5f1a to get more accurate results

@@           Coverage Diff           @@
##             main     #758   +/-   ##
=======================================
  Coverage   54.57%   54.57%           
=======================================
  Files         124      124           
  Lines       15249    15249           
=======================================
  Hits         8322     8322           
  Misses       6927     6927           

@IndrajeetPatil
Copy link
Member

Check succeeds now. I changed the R version from devel to release. I think that was the issue.
We shouldn't be running this check on R-devel.

@strengejacke
Copy link
Member Author

Cool thanks 👍

@strengejacke strengejacke merged commit ab0dd3a into main Sep 18, 2023
23 of 25 checks passed
@strengejacke strengejacke deleted the strengejacke/issue757 branch September 18, 2023 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests failing in random order (again)
3 participants