Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft report_s() #384

Merged
merged 11 commits into from
Dec 7, 2023
Merged

Draft report_s() #384

merged 11 commits into from
Dec 7, 2023

Conversation

strengejacke
Copy link
Member

@strengejacke strengejacke commented Jul 26, 2023

I still need to add something to the docs, about interpretation, underlying statistical concepts etc.

Copy link
Contributor

@bwiernik bwiernik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few phrasing suggestions. I think making it clear what the "test hypothesis" means (defaulting to "parameter = 0" but customizable) is probably important to avoid folks equating the phrase with their scientific hypothesis.

R/report_s.R Outdated Show resolved Hide resolved
R/report_s.R Outdated Show resolved Hide resolved
R/report_s.R Outdated Show resolved Hide resolved
strengejacke and others added 4 commits July 27, 2023 09:27
Co-authored-by: Brenton M. Wiernik <[email protected]>
Co-authored-by: Brenton M. Wiernik <[email protected]>
Co-authored-by: Brenton M. Wiernik <[email protected]>
@rempsyc
Copy link
Member

rempsyc commented Aug 13, 2023

All tests pass but it still says that we cannot merge because changes are requested. But it seems like you have addressed them @strengejacke? We could bypass branch protections but I would just like to understand what it requires to pass this check? Does it need to be Brenton that approves the new changes?

@rempsyc rempsyc self-requested a review August 13, 2023 15:30
@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d21dd4a) 73.74% compared to head (cae0972) 72.37%.
Report is 7 commits behind head on main.

❗ Current head cae0972 differs from pull request most recent head bbc47d4. Consider uploading reports for the commit bbc47d4 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #384      +/-   ##
==========================================
- Coverage   73.74%   72.37%   -1.38%     
==========================================
  Files          50       48       -2     
  Lines        3546     3330     -216     
==========================================
- Hits         2615     2410     -205     
+ Misses        931      920      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@strengejacke
Copy link
Member Author

I think Benton has to approve my latest changes in response to his review

@strengejacke strengejacke merged commit 16afa3b into main Dec 7, 2023
21 of 26 checks passed
@strengejacke strengejacke deleted the report_s branch December 7, 2023 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants