-
-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft report_s()
#384
Draft report_s()
#384
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few phrasing suggestions. I think making it clear what the "test hypothesis" means (defaulting to "parameter = 0" but customizable) is probably important to avoid folks equating the phrase with their scientific hypothesis.
Co-authored-by: Brenton M. Wiernik <[email protected]>
Co-authored-by: Brenton M. Wiernik <[email protected]>
Co-authored-by: Brenton M. Wiernik <[email protected]>
All tests pass but it still says that we cannot merge because changes are requested. But it seems like you have addressed them @strengejacke? We could bypass branch protections but I would just like to understand what it requires to pass this check? Does it need to be Brenton that approves the new changes? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #384 +/- ##
==========================================
- Coverage 73.74% 72.37% -1.38%
==========================================
Files 50 48 -2
Lines 3546 3330 -216
==========================================
- Hits 2615 2410 -205
+ Misses 931 920 -11 ☔ View full report in Codecov by Sentry. |
I think Benton has to approve my latest changes in response to his review |
I still need to add something to the docs, about interpretation, underlying statistical concepts etc.