Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check test failures on oldrel-Windows #349

Merged
merged 3 commits into from
Jul 16, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
Type: Package
Package: see
Title: Model Visualisation Toolbox for 'easystats' and 'ggplot2'
Version: 0.8.4.7
Authors@R:
Version: 0.8.4.8
Authors@R:
c(person(given = "Daniel",
family = "Lüdecke",
role = c("aut", "ctb"),
Expand Down Expand Up @@ -52,7 +52,7 @@ Maintainer: Indrajeet Patil <[email protected]>
Description: Provides plotting utilities supporting packages in the 'easystats'
ecosystem (<https://github.com/easystats/easystats>) and some extra themes,
geoms, and scales for 'ggplot2'. Color scales are based on
<https://materialui.co/>.
<https://materialui.co/>.
References: Lüdecke et al. (2021) <doi:10.21105/joss.03393>.
License: MIT + file LICENSE
URL: https://easystats.github.io/see/
Expand Down
4 changes: 2 additions & 2 deletions NAMESPACE
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@ S3method(data_plot,performance_pp_check)
S3method(data_plot,point_estimate)
S3method(data_plot,rope)
S3method(data_plot,see_compare_parameters)
S3method(plot,dw_data_tabulate)
S3method(plot,dw_data_tabulates)
S3method(plot,datawizard_table)
S3method(plot,datawizard_tables)
S3method(plot,see_bayesfactor_models)
S3method(plot,see_bayesfactor_parameters)
S3method(plot,see_bayesfactor_savagedickey)
Expand Down
5 changes: 4 additions & 1 deletion NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@

* Gets rid of warnings due to API changes in the `{datawizard}` package.

## Bug fixes

* Fixed CRAN test failures.

# see 0.8.4

## Minor Changes
Expand Down Expand Up @@ -626,4 +630,3 @@
## Bug fixes

* Fixed issues with color codes in the flat-ui palette.

12 changes: 6 additions & 6 deletions R/plot.dw_data_tabulate.R
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,10 @@
#' Interval estimation for a binomial proportion.
#' _Statistical Science_, _16_(2), 101-133. \doi{10.1214/ss/1009213286}
#'
#' @rdname plot.dw_data_tabulate
#' @rdname plot.datawizard_table
#' @export

plot.dw_data_tabulates <- function(x, label_values = TRUE,
plot.datawizard_tables <- function(x, label_values = TRUE,
show_na = c("if_any", "always", "never"),
na_label = "(Missing)",
error_bar = TRUE,
Expand All @@ -34,7 +34,7 @@ plot.dw_data_tabulates <- function(x, label_values = TRUE,
...) {
show_na <- match.arg(show_na, choices = c("if_any", "always", "never"))
if (length(x) == 1L) {
plot.dw_data_tabulate(
plot.datawizard_table(
x[[1]],
label_values = label_values,
show_na = show_na,
Expand All @@ -47,7 +47,7 @@ plot.dw_data_tabulates <- function(x, label_values = TRUE,
} else {
lapply(
x,
plot.dw_data_tabulate,
plot.datawizard_table,
label_values = label_values,
show_na = show_na,
na_label = na_label,
Expand All @@ -59,11 +59,11 @@ plot.dw_data_tabulates <- function(x, label_values = TRUE,
}
}

#' @rdname plot.dw_data_tabulate
#' @rdname plot.datawizard_table
#'
#' @export

plot.dw_data_tabulate <- function(x, label_values = TRUE,
plot.datawizard_table <- function(x, label_values = TRUE,
show_na = c("if_any", "always", "never"),
na_label = "(Missing)",
error_bar = TRUE,
Expand Down
10 changes: 5 additions & 5 deletions man/plot.dw_data_tabulate.Rd → man/plot.datawizard_table.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions tests/testthat/test-plot.dw_data_tabulate.R
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
test_that("`plot.dw_data_tabulate()` works with single table", {
test_that("`plot.datawizard_table()` works with single table", {
x <- datawizard::data_tabulate(mtcars, select = "cyl")
expect_s3_class(plot(x), "gg")
})

test_that("`plot.dw_data_tabulate()` works with multiple tables", {
test_that("`plot.datawizard_table()` works with multiple tables", {
x <- datawizard::data_tabulate(mtcars, select = c("cyl", "carb", "am"))
expect_true(is.list(plot(x)))

Check warning on line 8 in tests/testthat/test-plot.dw_data_tabulate.R

View workflow job for this annotation

GitHub Actions / lint-changed-files / lint-changed-files

file=tests/testthat/test-plot.dw_data_tabulate.R,line=8,col=3,[expect_type_linter] expect_type(x, t) is better than expect_true(is.<t>(x))
})
Loading