Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional documentation for configuring the SGP for initializing phase. #19

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mikailcolak
Copy link

@mikailcolak mikailcolak commented Mar 9, 2022

To keep the behavior of the previous version after upgrading the SPG, we have needed to alter the initialization via the described method in README.md within this PR.

And we thought documenting this may help the persons of interest.

…del definition replaced with an interface so message updated accordingly.
With an example for how to provide customized PermissionInitializer.
@mikailcolak mikailcolak requested a review from vladaspasic March 9, 2022 11:49
@github-actions
Copy link

github-actions bot commented Mar 9, 2022

File Coverage [39.47%]
GranularPermissionsAutoConfiguration.java 39.47%
Total Project Coverage 86.46% 🍏

@iznenad
Copy link
Contributor

iznenad commented Mar 14, 2022

I still believe that the library itself should not remove permissions by default. Once removed, and in the case where removal was accidental, the permissions would need to be manually added back to customer roles. This would cause a much bigger impact than some unused permissions sitting in the database. Hence, i'd prefer if we have to configure the library to remove permissions rather than the opposite. In the perfect case the library just doesn't care about this and the app developer has to think about this. I like very much the idea of reporting such unused permissions by logging.

@vladaspasic
Copy link
Contributor

I still believe that the library itself should not remove permissions by default. Once removed, and in the case where removal was accidental, the permissions would need to be manually added back to customer roles. This would cause a much bigger impact than some unused permissions sitting in the database. Hence, i'd prefer if we have to configure the library to remove permissions rather than the opposite. In the perfect case the library just doesn't care about this and the app developer has to think about this. I like very much the idea of reporting such unused permissions by logging.

Why not toggle the behaviour of the using properties? By default it can be turned off

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants