feat(nx-docker): add labels options to docker build executor #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnitvn
force-pushed
the
feat/nx-docker/labels
branch
from
17cd7eb to
7a4ebb8
Compare
…cker executor schema BREAKING CHANGE: Change the api of the Docker executor schema The `registries`, `version`, and `namespace` options have been added to the Docker executor schema. This change is backwards incompatible and may require updates to existing configurations.
johnitvn
force-pushed
the
feat/nx-docker/labels
branch
from
e2fafda to
4f2c006
Compare
johnitvn
force-pushed
the
feat/nx-docker/labels
branch
from
652e785 to
fbbea34
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several changes to the
nx-dockerpackage, specifically enhancing the Docker build executor by adding support for labels and updating the corresponding tests and schema. The most important changes include adding label arguments to the Docker build command, updating the executor tests to cover the new functionality, and modifying the schema to include labels.Enhancements to Docker build executor:
packages/nx-docker/src/executors/build/executor.ts: Added support for Docker labels by introducinglabelsArgswhich are appended to the Docker build command if labels are provided. [1] [2]Updates to executor tests:
packages/nx-docker/src/executors/build/executor.spec.ts: Added new tests to verify that Docker images are built with or without label arguments based on the provided options.packages/nx-docker/src/executors/build/executor.spec.ts: Removed the unusedcioption from the default options in the test setup.Schema modifications:
packages/nx-docker/src/executors/build/schema.json: Updated the schema to include thelabelsproperty, allowing users to specify labels for Docker images.