Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work on AASList / AASListDetails / AASTreeview / SubmodelList #135

Draft
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

seicke
Copy link
Member

@seicke seicke commented Dec 8, 2024

Description of Changes

1) no longer manually closable AASListDetails anymore

If aas-gui will be opening (without aas path parameter) the AASListDetails will be hide. The AAS List has its maximal height.

  • Click on an AAS of the AASList opens the AASListDetails of the selected AAS; at the same time AASList will be downsized. AASList as well as AASListDetails will be shown.
  • Further click on the same AAS closes the AASListDetails (= deselecting AAS); at the same time AASList will be enlarged back to its maximal height

2) Introduce new ENV variable SINGLE_AAS_REDIRECT

If variable is set as an URL

  • the aas-gui will only show a single aas. The AASList will be hide, AASListDetails has its maximal heigth.
  • the aas-gui hast to be opened with an aas path parameter, otherwise you will be redirected to the URL specified in the ENV variable SINGLE_AAS_REDIRECT

3) v-empty-state for no existing submodels in selected aas

Rules

PR#111 and PR#113 should be merged first.

@seicke seicke marked this pull request as ready for review December 8, 2024 08:05
Copy link
Member

@aaronzi aaronzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this very cool PR. I have some small suggestions:

  • Separate in two env variables (activate feature, redirect URL)
  • When feature is active and redirect URL invalid/not set a new 404 Page should be shown

@seicke seicke marked this pull request as draft December 15, 2024 04:32
@seicke seicke changed the title Work on AASList / AASListDetails Work on AASList / AASListDetails / AASTreeview / SubmodelList Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants