-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Work on AASList / AASListDetails / AASTreeview / SubmodelList #135
Draft
seicke
wants to merge
14
commits into
eclipse-basyx:main
Choose a base branch
from
seicke:single-aas
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronzi
requested changes
Dec 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this very cool PR. I have some small suggestions:
- Separate in two env variables (activate feature, redirect URL)
- When feature is active and redirect URL invalid/not set a new 404 Page should be shown
seicke
changed the title
Work on AASList / AASListDetails
Work on AASList / AASListDetails / AASTreeview / SubmodelList
Dec 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
1) no longer manually closable AASListDetails anymore
If aas-gui will be opening (without aas path parameter) the AASListDetails will be hide. The AAS List has its maximal height.
2) Introduce new ENV variable SINGLE_AAS_REDIRECT
If variable is set as an URL
3) v-empty-state for no existing submodels in selected aas
Rules
PR#111 and PR#113 should be merged first.