Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Visualization for AAS Viewer #77

Merged

Conversation

seicke
Copy link
Member

@seicke seicke commented Oct 31, 2024

Description of Changes

Opening the Submodel "DemoSubmodelV3" of Test AAS "Demo AAS V3" in AAS Viewer:

before

After fix:
localhost_3999_aasviewer_aas=http___localhost_9981_shells_aHR0cHM6Ly9odHctYmVybGluLmRlL2lkcy9hYXMvZGVtb2Fhc3Yz path=http___localhost_9981_submodels_aHR0cHM6Ly9odHctYmVybGluLmRlL2lkcy9zbS9kZW1 (1)

BaSyx Configuration for Testing

https://github.com/eclipse-basyx/basyx-java-server-sdk/tree/main/examples/BaSyxMinimal

@seicke seicke changed the title Fix Fix Visualization for AAS Viewer Oct 31, 2024
@seicke seicke requested a review from aaronzi October 31, 2024 14:12
@seicke seicke marked this pull request as ready for review October 31, 2024 14:12
@aaronzi
Copy link
Member

aaronzi commented Oct 31, 2024

Thanks for finding this bug, which renders both the generic submodel visualization and a custom plugin if its semanticId configuration matches the semanticId of the submodel in the viewerMode.

The fix you suggested actually removes the wrong visualization. If a custom plugin matches based on the semanticId, the custom plugin should be shown, not the generic submodel visualization. I have pushed a new commit that addresses this issue.

Still, the BaSyxMinimal example looks weird for the DemoSubmodelV3. The reason is the wrong usage of the custom hello world plugin for a submodel containing SubmodelElementCollections, which was not intended by the custom plugin. This should be fixed by updating the Demo AAS V3 in the BaSyxMinimal example and removing the usage of the custom plugin here. Perhaps a second "flat" submodel should be introduced, which can then use the hello world plugin.

@aaronzi aaronzi merged commit 2f0e0ad into eclipse-basyx:main Oct 31, 2024
2 checks passed
@seicke seicke deleted the fix-generic-data-visu-for-aas-viewer branch November 4, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants