Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Showing name of AAS in submodel list component and autoscrolling to selected AAS #97

Merged
merged 6 commits into from
Nov 13, 2024

Conversation

seicke
Copy link
Member

@seicke seicke commented Nov 12, 2024

Description of Changes

aas-name-aas-tree-view

Related Issue

Closes #86

BaSyx Configuration for Testing

https://github.com/eclipse-basyx/basyx-java-server-sdk/tree/main/examples/BaSyxMinimal

@seicke seicke marked this pull request as ready for review November 12, 2024 13:27
@seicke seicke requested a review from aaronzi November 12, 2024 13:27
Copy link
Member

@aaronzi aaronzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR. I noticed that the AAS Name is not shown in the SubmodelList on desktop when in the viewer mode. Could you please add this as well?

@seicke
Copy link
Member Author

seicke commented Nov 13, 2024

There is still another bug:
If you open the GUI with aas query parameter, the AAS is selected (in the AAS list), but the name is not shown in the AASTreeView/SubmodelList.

@aaronzi
Copy link
Member

aaronzi commented Nov 13, 2024

You are right, good find. I will try to fix this.

Update: On initial load, the needed information is not present because only the endpoint can be constructed out of the query param coming from the address bar:

{
  "endpoints": [
    {
      "protocolInformation": {
        "href": "http://localhost:8081/shells/aHR0cHM6Ly9leGFtcGxlLmNvbS9pZHMvYWFzLzkyMDRfNjA5MV84MDQyXzczNzQ"
      },
      "interface": "AAS-3.0"
    }
  ]
}

@seicke
Copy link
Member Author

seicke commented Nov 13, 2024

Right, opening the GUI with aas query parameter is resulting in

  1. dispatchingSelectedAAS as object only containing the endpoint (via AASList.vue | mounted())
  2. dispatchingSelectedAAS as object only containing the endpoint (viaApp.vue)

From my point of view it should be sufficient if mounted() of AASList.vue will dispatch not just the endpoint of the AAS.

@aaronzi aaronzi changed the title Showing name of the AAS at the top of the submodel list Showing name of AAS in submodel list component and autoscrolling to selected AAS Nov 13, 2024
@aaronzi aaronzi merged commit aa6748c into eclipse-basyx:main Nov 13, 2024
2 checks passed
@seicke seicke deleted the aas-name-submodel-list branch November 13, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] "Jumping" to an AAS should reveal the AAS in the AAS list
2 participants