Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration-Test-Suite for aasenvironment-component #137

Merged
merged 31 commits into from
Nov 20, 2023

Conversation

ahoimariew
Copy link
Contributor

integrated
-AasRepositoryIT
-SubmodelRepositoryIT
-ConceptDescriptionRepository
in AasEnvironment.component IT Testsuite

author:
@ahoimariew

co-authors:
@jannisjung
@FrankSchnicke
@mdanish98

ahoimariew and others added 29 commits August 17, 2023 16:34
Co-authored-by: Marie Witt <[email protected]>

Signed-off-by: Jannis Jung <[email protected]>
Co-authored-by: Marie Witt <[email protected]>
Signed-off-by: Jannis Jung <[email protected]>
Co-authored-by: Marie Witt <[email protected]>
Signed-off-by: Jannis Jung <[email protected]>
Co-authored-by: Marie Witt <[email protected]>
Signed-off-by: Jannis Jung <[email protected]>
Co-authored-by: Marie Witt <[email protected]>
Signed-off-by: Jannis Jung <[email protected]>
Co-authored-by: Marie Witt <[email protected]>
Signed-off-by: Jannis Jung <[email protected]>
Co-authored-by: Marie Witt <[email protected]>
Signed-off-by: Jannis Jung <[email protected]>
Co-authored-by: Marie Witt <[email protected]>
Co-authored-by: Frank Schnicke <[email protected]>
Signed-off-by: Jannis Jung <[email protected]>
Co-authored-by: Marie Witt <[email protected]>
Signed-off-by: Jannis Jung <[email protected]>
Co-authored-by: Marie Witt <[email protected]>
Signed-off-by: Jannis Jung <[email protected]>
Co-authored-by: Marie Witt <[email protected]
Signed-off-by: Jannis Jung <[email protected]>
Signed-off-by: Jannis Jung <[email protected]>
Co-authored-by: Marie Witt <[email protected]>
Signed-off-by: Jannis Jung <[email protected]>
Copy link
Contributor

@mdanish98 mdanish98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following are some minor review remarks.

@@ -16,17 +16,47 @@
</properties>

<dependencies>

<dependency>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This dependency can be removed as it is unnecessary.

*/

@RunWith(Suite.class)
@Suite.SuiteClasses({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use BaSyx formatting here.

Copy link
Contributor

@mdanish98 mdanish98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@FrankSchnicke FrankSchnicke merged commit c6a8f06 into eclipse-basyx:main Nov 20, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants