Implements AAS and SM Repo integration with Registries feature #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mohammad Ghazanfar Ali Danish <[email protected]>
…rver-sdk into feature/registry-integration
Signed-off-by: Mohammad Ghazanfar Ali Danish <[email protected]>
Signed-off-by: Mohammad Ghazanfar Ali Danish <[email protected]>
Signed-off-by: Mohammad Ghazanfar Ali Danish <[email protected]>
Signed-off-by: Mohammad Ghazanfar Ali Danish <[email protected]>
Signed-off-by: Mohammad Ghazanfar Ali Danish <[email protected]>
Signed-off-by: Mohammad Ghazanfar Ali Danish <[email protected]>
Signed-off-by: Mohammad Ghazanfar Ali Danish <[email protected]>
Signed-off-by: Mohammad Ghazanfar Ali Danish <[email protected]>
Signed-off-by: Mohammad Ghazanfar Ali Danish <[email protected]>
Signed-off-by: Mohammad Ghazanfar Ali Danish <[email protected]>
Signed-off-by: Mohammad Ghazanfar Ali Danish <[email protected]>
Signed-off-by: Mohammad Ghazanfar Ali Danish <[email protected]>
Signed-off-by: Mohammad Ghazanfar Ali Danish <[email protected]>
Signed-off-by: Mohammad Ghazanfar Ali Danish <[email protected]>
Signed-off-by: Mohammad Ghazanfar Ali Danish <[email protected]>
* Establishes compliance with naming guidelines * reunions organization line in parent pom * applies BaSyx formatter Signed-off-by: Jannis Jung <[email protected]>
jannisjung
reviewed
Nov 23, 2023
|
|
||
| @Override | ||
| public boolean isEnabled() { | ||
| return true; |
There was a problem hiding this comment.
should only return true, when basyx.aasrepository.feature.registryintegration=$AAS_Registry_URL and basyx.externalurl=.. ist set.
There was a problem hiding this comment.
Updated this in the latest commit.
|
|
||
| @Override | ||
| public boolean isEnabled() { | ||
| return true; |
There was a problem hiding this comment.
should only return true, when basyx.submodelrepository.feature.registryintegration=$AAS_Registry_URL and basyx.externalurl=.. ist set.
There was a problem hiding this comment.
Updated this in the latest commit.
Signed-off-by: Mohammad Ghazanfar Ali Danish <[email protected]>
Signed-off-by: Mohammad Ghazanfar Ali Danish <[email protected]>
jannisjung
approved these changes
Nov 24, 2023
- Changes related to serialization extension - Refactors RegIntegSMRepo and RegIntegAasRepo to check for descriptor before deletion - Swaps order of deletion from Repo and Registry Signed-off-by: Mohammad Ghazanfar Ali Danish <[email protected]>
Signed-off-by: Mohammad Ghazanfar Ali Danish <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mohammad Ghazanfar Ali Danish [email protected]