Add proxy build argument to dockerfiles #533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the PR. Could you please resolve the conflicts so that I can merge the changes? |
aaronzi
approved these changes
Dec 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
As a user within a corporate network (behind a proxy server), I also want to build Docker images.
This PR adds build arguments to all Dockerfiles to specify a proxy server.
The user can easily set the proxy server via shell ENV variables, e.g. in Powershell with
$ENV:HTTPS_PROXY='http://proxyserver:port'and$ENV:HTTP_PROXY='http://proxyserver:port'This PR does not affecting the Docker images builds if the corresponding ENV variables are not set.
Compare eclipse-basyx/basyx-aas-web-ui#84