Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implements InMemory AASX file server #84

Merged
merged 20 commits into from
Nov 8, 2023
Merged
Show file tree
Hide file tree
Changes from 13 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 39 additions & 0 deletions basyx.aasxfileserver/basyx.aasxfileserver-backend-inmemory/pom.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
<project xmlns="http://maven.apache.org/POM/4.0.0"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd">
<modelVersion>4.0.0</modelVersion>

<parent>
<groupId>org.eclipse.digitaltwin.basyx</groupId>
<artifactId>basyx.aasxfileserver</artifactId>
<version>${revision}</version>
</parent>

<artifactId>basyx.aasxfileserver-backend-inmemory</artifactId>
<name>AASX File Server Backend InMemory</name>

<dependencies>
<dependency>
<groupId>org.eclipse.digitaltwin.basyx</groupId>
<artifactId>basyx.aasxfileserver-core</artifactId>
</dependency>
<dependency>
<groupId>org.eclipse.digitaltwin.basyx</groupId>
<artifactId>basyx.aasxfileserver-core</artifactId>
<classifier>tests</classifier>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.springframework</groupId>
<artifactId>spring-context</artifactId>
</dependency>
<dependency>
<groupId>org.springframework.boot</groupId>
<artifactId>spring-boot-starter</artifactId>
</dependency>
<dependency>
<groupId>commons-io</groupId>
<artifactId>commons-io</artifactId>
<scope>test</scope>
</dependency>
</dependencies>
</project>
Original file line number Diff line number Diff line change
@@ -0,0 +1,139 @@
/*******************************************************************************
* Copyright (C) 2023 the Eclipse BaSyx Authors
*
* Permission is hereby granted, free of charge, to any person obtaining
* a copy of this software and associated documentation files (the
* "Software"), to deal in the Software without restriction, including
* without limitation the rights to use, copy, modify, merge, publish,
* distribute, sublicense, and/or sell copies of the Software, and to
* permit persons to whom the Software is furnished to do so, subject to
* the following conditions:
*
* The above copyright notice and this permission notice shall be
* included in all copies or substantial portions of the Software.
*
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
* MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE
* LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
* OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
* WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
*
* SPDX-License-Identifier: MIT
******************************************************************************/

package org.eclipse.digitaltwin.basyx.aasxfileserver;

import java.io.InputStream;
import java.util.Collection;
import java.util.LinkedHashMap;
import java.util.List;
import java.util.Map;
import java.util.concurrent.atomic.AtomicInteger;
import java.util.stream.Collectors;

import org.eclipse.digitaltwin.basyx.core.exceptions.CollidingIdentifierException;
import org.eclipse.digitaltwin.basyx.core.exceptions.ElementDoesNotExistException;

/**
* In-memory implementation of the AASXFileServer
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use @_link

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

*
* @author chaithra
*
*/
public class InMemoryAASXFileServer implements AASXFileServer {

private Map<String, Package> packageMap = new LinkedHashMap<>();
private AtomicInteger packageId = new AtomicInteger(0);

@Override
public Collection<PackageDescription> getAllAASXPackageIds() {
return packageMap.values()
.stream()
.map(Package::getPackageDescription)
.collect(Collectors.toList());
}

@Override
public InputStream getAASXByPackageId(String packageId) throws ElementDoesNotExistException {
throwIfAASXPackageIdDoesNotExist(packageId);

return packageMap.get(packageId).getPackagesBody().getFile();
}

@Override
public void updateAASXByPackageId(String packageId, List<String> aasIds, InputStream file, String filename)
throws ElementDoesNotExistException {

throwIfAASXPackageIdDoesNotExist(packageId);

updateAASXPackage(packageId, aasIds, file, filename);
}

@Override
public PackageDescription createAASXPackage(List<String> aasIds, InputStream file, String fileName)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As identifier is generated automatically at runtime, there is no chance of collision.

Please remove this throws declaration.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

throws CollidingIdentifierException {

String newpackageId = String.valueOf(packageId.incrementAndGet());

PackageDescription packageDescription = createPackageDescription(aasIds, newpackageId);

createPackage(aasIds, file, fileName, newpackageId, packageDescription);

return packageDescription;
}

@Override
public void deleteAASXByPackageId(String packageId) throws ElementDoesNotExistException {
throwIfAASXPackageIdDoesNotExist(packageId);

packageMap.remove(packageId);
}

private PackageDescription createPackageDescription(List<String> aasIds, String newPackageId) {
PackageDescription packageDescription = new PackageDescription();
packageDescription.packageId(newPackageId);
packageDescription.aasIds(aasIds);

return packageDescription;
}

private PackagesBody createPackagesBody(List<String> aasIds, InputStream file, String fileName) {
PackagesBody packagesBody = new PackagesBody();
packagesBody.aasIds(aasIds);
packagesBody.file(file);
packagesBody.fileName(fileName);

return packagesBody;
}

private void createPackage(List<String> aasIds, InputStream file, String fileName, String newPackageId, PackageDescription packageDescription) {
PackagesBody packagesBody = createPackagesBody(aasIds, file, fileName);

Package aasxPackage = new Package(newPackageId, packageDescription, packagesBody);

packageMap.put(newPackageId, aasxPackage);
}

private void updateAASXPackage(String packageId, List<String> aasIds, InputStream file, String filename) {
Package aasxPackage = this.packageMap.get(packageId);

updatePackagesBody(aasIds, file, filename, aasxPackage.getPackagesBody());

aasxPackage.getPackageDescription().setAasIds(aasIds);
}

private void updatePackagesBody(List<String> aasIds, InputStream file, String filename, PackagesBody packagesBody) {
packagesBody.setAasIds(aasIds);
packagesBody.setFileName(filename);
packagesBody.setFile(file);
}

private void throwIfAASXPackageIdDoesNotExist(String id) {

if (!packageMap.containsKey(id))
throw new ElementDoesNotExistException(id);
}

}
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
/*******************************************************************************
* Copyright (C) 2023 the Eclipse BaSyx Authors
*
* Permission is hereby granted, free of charge, to any person obtaining a copy
* of this software and associated documentation files (the "Software"), to deal
* in the Software without restriction, including without limitation the rights
* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
* copies of the Software, and to permit persons to whom the Software is
* furnished to do so, subject to the following conditions:
*
* The above copyright notice and this permission notice shall be included in
* all copies or substantial portions of the Software.
*
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
* SOFTWARE.
*
* SPDX-License-Identifier: MIT
******************************************************************************/

package org.eclipse.digitaltwin.basyx.aasxfileserver;

import org.springframework.boot.autoconfigure.condition.ConditionalOnExpression;
import org.springframework.stereotype.Component;

/**
* AasxFileServer factory returning an in-memory backend {@link AASXFileServer}
KBChaithra marked this conversation as resolved.
Show resolved Hide resolved
*
* @author schnicke, chaithra
*/
@Component
@ConditionalOnExpression("'${basyx.backend}'.equals('InMemory')")
public class InMemoryAASXFileServerFactory implements AASXFileServerFactory {

@Override
public AASXFileServer create() {
return new InMemoryAASXFileServer();
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
/*******************************************************************************
* Copyright (C) 2023 the Eclipse BaSyx Authors
*
* Permission is hereby granted, free of charge, to any person obtaining
* a copy of this software and associated documentation files (the
* "Software"), to deal in the Software without restriction, including
* without limitation the rights to use, copy, modify, merge, publish,
* distribute, sublicense, and/or sell copies of the Software, and to
* permit persons to whom the Software is furnished to do so, subject to
* the following conditions:
*
* The above copyright notice and this permission notice shall be
* included in all copies or substantial portions of the Software.
*
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
* MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE
* LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
* OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
* WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
*
* SPDX-License-Identifier: MIT
******************************************************************************/

package org.eclipse.digitaltwin.basyx.aasxfileserver;

import org.eclipse.digitaltwin.basyx.aasxfileserver.core.AASXFileServerSuite;

/**
* Tests the {@link InMemoryAASXFileServer}
*
* @author chaithra
*
*/
public class TestInMemoryAASXFileServer extends AASXFileServerSuite {

@Override
protected AASXFileServer getAASXFileServer() {
return new InMemoryAASXFileServer();
}

}
33 changes: 33 additions & 0 deletions basyx.aasxfileserver/basyx.aasxfileserver-core/pom.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
<project xmlns="http://maven.apache.org/POM/4.0.0"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd">
<modelVersion>4.0.0</modelVersion>

<parent>
<groupId>org.eclipse.digitaltwin.basyx</groupId>
<artifactId>basyx.aasxfileserver</artifactId>
<version>${revision}</version>
</parent>

<artifactId>basyx.aasxfileserver-core</artifactId>
<name>AASX File Server Core</name>

<dependencies>
<dependency>
<groupId>org.eclipse.digitaltwin.basyx</groupId>
<artifactId>basyx.core</artifactId>
</dependency>

<dependency>
<groupId>org.eclipse.digitaltwin.aas4j</groupId>
<artifactId>model</artifactId>
</dependency>
<dependency>
<groupId>commons-io</groupId>
<artifactId>commons-io</artifactId>
<scope>test</scope>
</dependency>

</dependencies>


</project>
Original file line number Diff line number Diff line change
@@ -0,0 +1,87 @@
/*******************************************************************************
* Copyright (C) 2023 the Eclipse BaSyx Authors
*
* Permission is hereby granted, free of charge, to any person obtaining
* a copy of this software and associated documentation files (the
* "Software"), to deal in the Software without restriction, including
* without limitation the rights to use, copy, modify, merge, publish,
* distribute, sublicense, and/or sell copies of the Software, and to
* permit persons to whom the Software is furnished to do so, subject to
* the following conditions:
*
* The above copyright notice and this permission notice shall be
* included in all copies or substantial portions of the Software.
*
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
* MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE
* LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
* OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
* WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
*
* SPDX-License-Identifier: MIT
******************************************************************************/

package org.eclipse.digitaltwin.basyx.aasxfileserver;

import java.io.InputStream;
import java.util.Collection;
import java.util.List;

import org.eclipse.digitaltwin.basyx.core.exceptions.CollidingIdentifierException;
import org.eclipse.digitaltwin.basyx.core.exceptions.ElementDoesNotExistException;

/**
* Specifies the overall AasxFileServer API
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use @_link to reference classes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

*
* @author chaithra
*
*/
public interface AASXFileServer {

/**
* Retrieves all AASX package ids from the repository
*
* @return a list of available AASX Package Descriptions at the server
*/
public Collection<PackageDescription> getAllAASXPackageIds();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing param aasId (see SPOTAAS Part2, 5.5.2 Operation GetAllAASXPackageIds, p. 45)
e.g. overload method

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(according to our naming guide lines the param should be named shellId)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated this method


/**
* Retrieves a specific AASX package from the server
*
* @param packageId
* @return a specific AASX package from the server
* @throws ElementDoesNotExistException
*/
public InputStream getAASXByPackageId(String packageId) throws ElementDoesNotExistException;

/**
* Updates an existing AASX package at the server
*
* @param packageId
* @param aasIds
* @param file
* @param filename
* @throws ElementDoesNotExistException
*/
public void updateAASXByPackageId(String packageId, List<String> aasIds, InputStream file, String filename) throws ElementDoesNotExistException;

/**
* Creates a new AASX Package
*
* @param aasIds
* @param file
* @param filename
* @throws CollidingIdentifierException
*/
public PackageDescription createAASXPackage(List<String> aasIds, InputStream file, String fileName) throws CollidingIdentifierException;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As identifier is generated automatically at runtime, there is no chance of collision.

Please remove this throws declaration.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done


/**
* Deletes a AASX Package
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a vertical space below this line.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

* @param packageId
* @throws ElementDoesNotExistException
*/
public void deleteAASXByPackageId(String packageId) throws ElementDoesNotExistException;

}
Loading