[#149] Add interface and service to change configuration visibility #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…isibility The new interface ClangdConfigurationVisibility allows vendors to hide the 'Prefer C/C++ Editor (LSP)' check-box and the 'clangd options' group in the preference/properties page. fixes eclipse-cdt#149 eclipse-cdt#153
jonahgraham
reviewed
Aug 3, 2023
| @@ -33,6 +33,7 @@ Require-Bundle: org.eclipse.cdt.lsp;bundle-version="0.0.0", | |||
| org.eclipse.ui;bundle-version="0.0.0" | |||
| Bundle-Activator: org.eclipse.cdt.lsp.internal.clangd.editor.ClangdPlugin | |||
| Service-Component: OSGI-INF/org.eclipse.cdt.lsp.clangd.BuiltinClangdOptionsDefaults.xml, | |||
| OSGI-INF/org.eclipse.cdt.lsp.clangd.DefaultClangdConfigurationVisibility.xml, | |||
There was a problem hiding this comment.
I have barely used let alone reviewed this type of pattern - so I defer to @ruspl-afed to review this aspect. It looks ok to me, but I don't know what I could be missing.
ruspl-afed
reviewed
Aug 4, 2023
...ipse.cdt.lsp.clangd/src/org/eclipse/cdt/lsp/clangd/DefaultClangdConfigurationVisibility.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new interface ClangdConfigurationVisibility allows vendors to hide the 'Prefer C/C++ Editor (LSP)' check-box and the 'clangd options' group in the preference/properties page.
fixes #149
fixes #153