Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PCA, improve dbl click variable selection #1955

Conversation

lorenzgerber
Copy link
Contributor

  • so far nearest feature to dbl click was determined by sequential sort of delta X/Y, this does not result in every case in the closest geometric distance. Hence distance was added to FeatureDelta class.
  • x/y delta calculation did not work correct when the axis was limited to only positive or only negative values which resulted in wrong results specifically when zoomed in.

@eselmeister eselmeister merged commit f7dd80f into eclipse-chemclipse:develop Nov 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants