idlcxx: add cmake argument to search additional include directories #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matija Tudan <[email protected]>
eboasson
reviewed
Dec 13, 2021
There was a problem hiding this comment.
Makes sense to me, but it makes equal sense for other language bindings and so either this needs to be copied, or there should be a common IDL preprocessing function for all language bindings. The differences are really small, so it seems feasible.
It also would've ensured the cross-compilation PR #189 would have been unnecessary.
Would you be willing to have a look at a making a parameterized version of the generator function, add it to the cyclonedds and then use that one in the Generate.cmake there and here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Matija Tudan [email protected]