Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add profiles to conan install #401

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

reicheratwork
Copy link
Contributor

Conan requires profiles in the invoke of the install command starting with version 2.0, with it being an optional parameter at this time
Added the default profile to conan install to head this future issue off

Conan requires profiles in the invoke of the install command starting
with version 2.0, with it being an optional parameter right now
Added the default profile to conan install to head this possible issue
off

Signed-off-by: Martijn Reicher <[email protected]>
Copy link
Contributor

@eboasson eboasson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once we add the build profile, can we switch to Conan 2.0?

I also think we should do a PR for the core repository, having different ways of using Conan in the C and C++ repositories is asking for trouble. (Maybe it was a bad idea to have separate repositories, or maybe it would be a good idea to have the common build bits in yet another one that we import, or ... But right now the repositories are what they are.)

@reicheratwork
Copy link
Contributor Author

Once we add the build profile, can we switch to Conan 2.0?

I also think we should do a PR for the core repository, having different ways of using Conan in the C and C++ repositories is asking for trouble. (Maybe it was a bad idea to have separate repositories, or maybe it would be a good idea to have the common build bits in yet another one that we import, or ... But right now the repositories are what they are.)

As far as I know, this should make us ready for conan 2.0, yes.

I will also have a look at the CycloneDDS-C repo and see what's going on with conan there.

P.S.: this was fixed by using information from this issue on the conan github.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants