Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[License-Check-Workflow] Add licensecheck workflow for dash itself #329

Merged
merged 1 commit into from
Jul 13, 2024

Conversation

HannesWell
Copy link
Contributor

@waynebeaton what do you think about adding this?
To make this fully operational we would have to request an EF Gitlab API token, like in https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/1454.

@waynebeaton
Copy link
Collaborator

I like the idea conceptually. If it works, let's do it.

@HannesWell HannesWell marked this pull request as ready for review July 13, 2024 12:48
@HannesWell
Copy link
Contributor Author

I like the idea conceptually. If it works, let's do it.

Great, then lets have this.
Created https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/4822 to ask the infra team for a API token so that we can request reviews here too.
But this can already be submitted now, since we only need the token when requesting reviews.

@HannesWell HannesWell merged commit 5241b17 into eclipse-dash:master Jul 13, 2024
5 checks passed
@HannesWell HannesWell deleted the add-license-check branch July 13, 2024 12:49
@HannesWell
Copy link
Contributor Author

/request-license-review

1 similar comment
@HannesWell
Copy link
Contributor Author

/request-license-review

Copy link

/request-license-review

✔️ All licenses already successfully vetted.

Workflow run (with attached summary files):
https://github.com/eclipse-dash/dash-licenses/actions/runs/9980575655

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants