[core] Change entity_id type from std::string to uint64_t #1872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… unique within the system)
KerstinKeller
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -23,9 +23,10 @@ | |||
| **/ | |||
|
|
|||
| #pragma once | |||
| #include <cstdint> | |||
There was a problem hiding this comment.
warning: 'cstdint' file not found [clang-diagnostic-error]
#include <cstdint>
^| if (arg == nullptr) return false; | ||
| if (*arg == nullptr) return false; | ||
|
|
||
| size_t len = stream->bytes_left; |
There was a problem hiding this comment.
warning: variable 'len' of type 'size_t' (aka 'unsigned long') can be declared 'const' [misc-const-correctness]
Suggested change
| size_t len = stream->bytes_left; | |
| size_t const len = stream->bytes_left; |
Peguen
reviewed
Jan 6, 2025
| @@ -37,7 +37,7 @@ namespace eCAL | |||
| std::string host_name; | |||
| int32_t process_id = 0; | |||
| std::string topic_name; | |||
| std::string topic_id; | |||
| uint64_t topic_id = 0; | |||
There was a problem hiding this comment.
Why do you use here uint64_t while we have down below in AddSubscription/RemSubscription the Registration::EntityIdT ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Functional change: change map IDs from combined strings to entity_id only (as they are unique within the system)
The serialization format is kept as is for binary compatibility. E.g. while internally being handled as uint64_t, it is converted to a string on the wire, and parsed from the string upon deserialization.
Please review with regard to the following:
Name of EntityID type:
using EntityIdT = uint64_t;or ratherTEntityID(similar toSEntityID-> bit unhappy about naming here)