Add "replace" as a default available transformer #731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merks
reviewed
Dec 21, 2024
....equinox.transforms.hook/src/org/eclipse/equinox/internal/transforms/ReplaceTransformer.java
Outdated
Show resolved
Hide resolved
....equinox.transforms.hook/src/org/eclipse/equinox/internal/transforms/ReplaceTransformer.java
Outdated
Show resolved
Hide resolved
Test Results 663 files 663 suites 1h 14m 53s ⏱️ Results for commit b995f98. ♻️ This comment has been updated with latest results. |
laeubi
force-pushed
the
add_replace_transformer_as_default
branch
2 times, most recently
from
0da2a55 to
abd6756
Compare
laeubi
force-pushed
the
add_replace_transformer_as_default
branch
from
abd6756 to
7d3efe7
Compare
|
As no further concerns are raised and to unblock depending work I plan to merge this now. |
|
Currently build fails due to |
A while back in the incubation phase there was a dedicated bundle that provided a "replace" transformer. As this is the very basic transformation and do not require any special dependency it is now added back (in a slightly enhanced implementation) as being available by default.
laeubi
force-pushed
the
add_replace_transformer_as_default
branch
from
7d3efe7 to
b995f98
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A while back in the incubation phase there was a dedicated bundle that provided a "replace" transformer.
As this is the very basic transformation and do not require any special dependency it is now added back (in a slightly enhanced implementation) as being available by default.
This contributes to