Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iox-#1036 Builder pattern for message queue #2014

Conversation

elBoberido
Copy link
Member

@elBoberido elBoberido commented Sep 1, 2023

Pre-Review Checklist for the PR Author

  1. Code follows the coding style of CONTRIBUTING.md
  2. Tests follow the best practice for testing
  3. Changelog updated in the unreleased section including API breaking changes
  4. Branch follows the naming format (iox-123-this-is-a-branch)
  5. Commits messages are according to this guideline
  6. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  7. Relevant issues are linked
  8. Add sensible notes for the reviewer
  9. All checks have passed (except task-list-completed)
  10. All touched (C/C++) source code files from iceoryx_hoofs are added to ./clang-tidy-diff-scans.txt
  11. Assign PR to reviewer

Notes for Reviewer

This PR continues with the porting of the creation pattern to the builder pattern by taking care of the MessageQueue. The remaining classes will be done in a follow up.

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • All touched (C/C++) source code files from iceoryx_hoofs have been added to ./clang-tidy-diff-scans.txt
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

@elBoberido elBoberido added refactoring Refactor code without adding features technical debt unclean code and design flaws labels Sep 1, 2023
@elBoberido elBoberido self-assigned this Sep 1, 2023
Copy link
Contributor

@elfenpiff elfenpiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor findings. From my point of view it can be merged if these are addressed

@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Merging #2014 (3b67f47) into master (c58a4b8) will decrease coverage by 0.13%.
The diff coverage is 75.90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2014      +/-   ##
==========================================
- Coverage   74.31%   74.18%   -0.13%     
==========================================
  Files         414      415       +1     
  Lines       16085    16102      +17     
  Branches     2248     2254       +6     
==========================================
- Hits        11953    11945       -8     
- Misses       3416     3435      +19     
- Partials      716      722       +6     
Flag Coverage Δ
unittests 73.97% <75.90%> (-0.13%) ⬇️
unittests_timing 14.90% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...oofs/internal/posix_wrapper/unix_domain_socket.hpp 100.00% <ø> (ø)
...eoryx_posh/internal/runtime/ipc_interface_base.hpp 100.00% <ø> (ø)
iceoryx_posh/source/runtime/ipc_interface_base.cpp 62.74% <40.90%> (-7.71%) ⬇️
...ceoryx_dust/source/posix_wrapper/message_queue.cpp 63.26% <87.71%> (-1.17%) ⬇️
...clude/iceoryx_dust/posix_wrapper/message_queue.hpp 100.00% <100.00%> (ø)

... and 4 files with indirect coverage changes

@elBoberido elBoberido requested a review from elfenpiff September 1, 2023 18:12
@elBoberido elBoberido force-pushed the iox-1036-builder-pattern-for-message-queue branch from b2c853d to 3b7f0ce Compare September 1, 2023 18:29
@elBoberido elBoberido closed this Sep 1, 2023
@elBoberido elBoberido deleted the iox-1036-builder-pattern-for-message-queue branch September 1, 2023 18:50
@elBoberido elBoberido restored the iox-1036-builder-pattern-for-message-queue branch September 1, 2023 18:50
@elBoberido elBoberido reopened this Sep 1, 2023
@elBoberido elBoberido force-pushed the iox-1036-builder-pattern-for-message-queue branch from 3b7f0ce to 3b67f47 Compare September 1, 2023 19:29
@elBoberido elBoberido merged commit e70767a into eclipse-iceoryx:master Sep 4, 2023
17 of 18 checks passed
@elBoberido elBoberido deleted the iox-1036-builder-pattern-for-message-queue branch September 4, 2023 13:06
@elBoberido elBoberido linked an issue Sep 4, 2023 that may be closed by this pull request
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Refactor code without adding features technical debt unclean code and design flaws
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove creation design pattern class with in place implementation
3 participants