Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iox-#2384 mistype fix #2385

Merged

Conversation

EgorWeders
Copy link
Contributor

@EgorWeders EgorWeders commented Dec 9, 2024

Notes for Reviewer

Pre-Review Checklist for the PR Author

  1. Code follows the coding style of CONTRIBUTING.md
  2. Tests follow the best practice for testing
  3. Changelog updated in the unreleased section including API breaking changes
  4. Branch follows the naming format (iox-123-this-is-a-branch)
  5. Commits messages are according to this guideline
  6. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  7. Relevant issues are linked
  8. Add sensible notes for the reviewer
  9. All checks have passed (except task-list-completed)
  10. Assign PR to reviewer

Checklist for the PR Reviewer

  • Consider a second reviewer for complex new features or larger refactorings
  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • All touched (C/C++) source code files from iceoryx_hoofs have been added to ./clang-tidy-diff-scans.txt
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

@elBoberido
Copy link
Member

@EgorWeders can you add the following line to the refactoring section of the changelog in doc/website/release-notes/iceoryx-unreleased.md

- Mistype in readme file [#2384](https://github.com/eclipse-iceoryx/iceoryx/issues/2384)

Please also keep in mind to used the issue number for the commit message. If you install the git hooks, it will be taken care automatically.

Thanks for your patience

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.69%. Comparing base (085ac0a) to head (2b939e7).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2385   +/-   ##
=======================================
  Coverage   78.69%   78.69%           
=======================================
  Files         440      440           
  Lines       16981    16981           
  Branches     2361     2361           
=======================================
  Hits        13364    13364           
  Misses       2736     2736           
  Partials      881      881           
Flag Coverage Δ
unittests 78.49% <ø> (ø)
unittests_timing 15.36% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

@elBoberido
Copy link
Member

@EgorWeders we need to merge #2387 first. It seems the github CI upgraded bazel to v8.0, which broke be bazel CI build.

@elBoberido
Copy link
Member

@EgorWeders #2387 is now merged. Can you please rebase your branch to main nand force push

@EgorWeders EgorWeders force-pushed the iox-2384-readme-mistype-fix branch from c024513 to 2b939e7 Compare December 11, 2024 08:14
@elBoberido elBoberido merged commit b7a79cd into eclipse-iceoryx:main Dec 11, 2024
22 checks passed
@elBoberido
Copy link
Member

Thanks for your patience :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mistype in readme file
2 participants