Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename datapoints #108

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Rename datapoints #108

merged 1 commit into from
Nov 25, 2024

Conversation

erikbosch
Copy link
Contributor

@erikbosch erikbosch commented Nov 25, 2024

Based on a comment at #106 (comment) from @BjoernAtBosch

Should we possibly use data_points instead of datapoints. Most other members in v2 use the form data_point / data_points

If we are to change it, maybe it is good to change it now.

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.29%. Comparing base (6763a66) to head (3ccec36).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #108      +/-   ##
==========================================
+ Coverage   59.20%   59.29%   +0.09%     
==========================================
  Files          33       33              
  Lines       16063    16063              
==========================================
+ Hits         9510     9525      +15     
+ Misses       6553     6538      -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@erikbosch erikbosch marked this pull request as ready for review November 25, 2024 09:15
Copy link
Contributor

@lukasmittag lukasmittag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erikbosch erikbosch merged commit a5314a6 into eclipse-kuksa:main Nov 25, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants