Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use set_target_values isntead of set_current_values #70

Merged
merged 2 commits into from
Sep 25, 2024
Merged

Use set_target_values isntead of set_current_values #70

merged 2 commits into from
Sep 25, 2024

Conversation

lukasmittag
Copy link
Contributor

No description provided.

@lukasmittag lukasmittag mentioned this pull request Sep 25, 2024
Closed
@lukasmittag lukasmittag linked an issue Sep 25, 2024 that may be closed by this pull request
actuate leverages set_current_values instead of set_target_values #68
Closed
@codecov Codecov
Copy link

codecov bot commented Sep 25, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 50.46%. Comparing base (7951c62) to head (578f397).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
databroker-cli/src/kuksa_cli.rs 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main      #70   +/-   ##
=======================================
  Coverage   50.46%   50.46%           
=======================================
  Files          31       31           
  Lines       11697    11697           
=======================================
  Hits         5903     5903           
  Misses       5794     5794

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

rafaeling
rafaeling approved these changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@rafaeling rafaeling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rafaeling rafaeling merged commit 248d2a3 into eclipse-kuksa:main Sep 25, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafaeling rafaeling rafaeling approved these changes

Assignees

@argerus argerus

@rafaeling rafaeling

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

actuate leverages set_current_values instead of set_target_values
3 participants
@lukasmittag @rafaeling @argerus