Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Provider Actuation #73

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Implement Provider Actuation #73

merged 1 commit into from
Oct 14, 2024

Conversation

wba2hi
Copy link
Contributor

@wba2hi wba2hi commented Sep 27, 2024

No description provided.

wba2hi
wba2hi commented Sep 27, 2024
View reviewed changes
databroker/Cargo.toml Outdated Show resolved Hide resolved
@wba2hi wba2hi requested a review from argerus September 30, 2024 05:47
@codecov Codecov
Copy link

codecov bot commented Oct 1, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 79.49283% with 186 lines in your changes missing coverage. Please review.

Project coverage is 55.01%. Comparing base (4dce6f3) to head (1c95332).

Files with missing lines Patch % Lines
databroker/src/grpc/kuksa_val_v2/conversions.rs 12.84% 95 Missing ⚠️
databroker/src/broker.rs 71.42% 54 Missing ⚠️
databroker/src/grpc/kuksa_val_v2/val.rs 94.61% 32 Missing ⚠️
databroker/src/permissions.rs 66.66% 5 Missing ⚠️
Additional details and impacted files 
@@                      Coverage Diff                      @@
##           feature/databroker-api-v2      #73      +/-   ##
=============================================================
+ Coverage                      53.20%   55.01%   +1.81%     
=============================================================
  Files                             33       33              
  Lines                          13680    14528     +848     
=============================================================
+ Hits                            7278     7993     +715     
- Misses                          6402     6535     +133

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wba2hi wba2hi marked this pull request as ready for review October 1, 2024 08:35
lukasmittag
lukasmittag requested changes Oct 1, 2024
View reviewed changes
databroker/Cargo.toml Outdated Show resolved Hide resolved
databroker/src/grpc/kuksa_val_v2/val.rs Outdated Show resolved Hide resolved
lukasmittag
lukasmittag requested changes Oct 1, 2024
View reviewed changes
databroker/src/grpc/kuksa_val_v2/val.rs Outdated Show resolved Hide resolved
databroker/src/broker.rs Outdated Show resolved Hide resolved
databroker/src/broker.rs Outdated Show resolved Hide resolved
databroker/src/broker.rs Outdated Show resolved Hide resolved
databroker/src/grpc/kuksa_val_v2/val.rs Outdated Show resolved Hide resolved
databroker/src/grpc/kuksa_val_v2/val.rs Show resolved Hide resolved
databroker/src/broker.rs Outdated Show resolved Hide resolved
databroker/src/broker.rs Show resolved Hide resolved
databroker/src/broker.rs Outdated Show resolved Hide resolved
databroker/src/broker.rs Outdated Show resolved Hide resolved
erikbosch
erikbosch reviewed Oct 3, 2024
View reviewed changes
databroker/src/broker.rs Outdated Show resolved Hide resolved
erikbosch
erikbosch reviewed Oct 3, 2024
View reviewed changes
databroker/src/broker.rs Outdated Show resolved Hide resolved
erikbosch
erikbosch reviewed Oct 3, 2024
View reviewed changes
databroker/src/broker.rs Outdated Show resolved Hide resolved
erikbosch
erikbosch reviewed Oct 3, 2024
View reviewed changes
databroker/src/broker.rs Outdated Show resolved Hide resolved
@wba2hi wba2hi force-pushed the actuators branch 2 times, most recently from 08b7f18 to aa5f502 Compare October 8, 2024 05:47
@erikbosch erikbosch force-pushed the feature/databroker-api-v2 branch 2 times, most recently from 51d999c to 4dce6f3 Compare October 10, 2024 13:59
@wba2hi
Copy link
Contributor Author

wba2hi commented Oct 11, 2024

Rebased and squashed the branch to a single commit

@wba2hi @argerus
Implement Provider Actuation
b9c9851 
Co-authored-by: John Argérus <[email protected]>
erikbosch
erikbosch approved these changes Oct 14, 2024
View reviewed changes
Copy link
Contributor

@erikbosch erikbosch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erikbosch erikbosch merged commit 35c0f83 into eclipse-kuksa:feature/databroker-api-v2 Oct 14, 2024
23 checks passed
@erikbosch erikbosch deleted the actuators branch October 14, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukasmittag lukasmittag lukasmittag requested changes

@erikbosch erikbosch erikbosch approved these changes

@argerus argerus argerus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wba2hi @argerus @erikbosch @lukasmittag